Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc

Issue 11312228: Move extension_error_utils.* and url_pattern_set.* into (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hate Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "base/string_number_conversions.h" 7 #include "base/string_number_conversions.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/common/extensions/extension_error_utils.h"
10 #include "chrome/common/extensions/extension_manifest_constants.h" 9 #include "chrome/common/extensions/extension_manifest_constants.h"
10 #include "extensions/common/error_utils.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "webkit/glue/web_intent_service_data.h" 12 #include "webkit/glue/web_intent_service_data.h"
13 13
14 using extensions::ErrorUtils;
14 using extensions::Extension; 15 using extensions::Extension;
15 16
16 namespace errors = extension_manifest_errors; 17 namespace errors = extension_manifest_errors;
17 18
18 TEST_F(ExtensionManifestTest, WebAccessibleResources) { 19 TEST_F(ExtensionManifestTest, WebAccessibleResources) {
19 // Manifest version 2 with web accessible resources specified. 20 // Manifest version 2 with web accessible resources specified.
20 scoped_refptr<Extension> extension1( 21 scoped_refptr<Extension> extension1(
21 LoadAndExpectSuccess("web_accessible_resources_1.json")); 22 LoadAndExpectSuccess("web_accessible_resources_1.json"));
22 23
23 // Manifest version 2 with no web accessible resources. 24 // Manifest version 2 with no web accessible resources.
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 ASSERT_EQ(1u, extension->intents_services().size()); 208 ASSERT_EQ(1u, extension->intents_services().size());
208 EXPECT_EQ("chrome-extension", 209 EXPECT_EQ("chrome-extension",
209 extension->intents_services()[0].service_url.scheme()); 210 extension->intents_services()[0].service_url.scheme());
210 EXPECT_EQ("/main.html",extension->intents_services()[0].service_url.path()); 211 EXPECT_EQ("/main.html",extension->intents_services()[0].service_url.path());
211 } 212 }
212 213
213 TEST_F(ExtensionManifestTest, AppWebUrls) { 214 TEST_F(ExtensionManifestTest, AppWebUrls) {
214 Testcase testcases[] = { 215 Testcase testcases[] = {
215 Testcase("web_urls_wrong_type.json", errors::kInvalidWebURLs), 216 Testcase("web_urls_wrong_type.json", errors::kInvalidWebURLs),
216 Testcase("web_urls_invalid_1.json", 217 Testcase("web_urls_invalid_1.json",
217 ExtensionErrorUtils::FormatErrorMessage( 218 ErrorUtils::FormatErrorMessage(
218 errors::kInvalidWebURL, 219 errors::kInvalidWebURL,
219 base::IntToString(0), 220 base::IntToString(0),
220 errors::kExpectString)), 221 errors::kExpectString)),
221 Testcase("web_urls_invalid_2.json", 222 Testcase("web_urls_invalid_2.json",
222 ExtensionErrorUtils::FormatErrorMessage( 223 ErrorUtils::FormatErrorMessage(
223 errors::kInvalidWebURL, 224 errors::kInvalidWebURL,
224 base::IntToString(0), 225 base::IntToString(0),
225 URLPattern::GetParseResultString( 226 URLPattern::GetParseResultString(
226 URLPattern::PARSE_ERROR_MISSING_SCHEME_SEPARATOR))), 227 URLPattern::PARSE_ERROR_MISSING_SCHEME_SEPARATOR))),
227 Testcase("web_urls_invalid_3.json", 228 Testcase("web_urls_invalid_3.json",
228 ExtensionErrorUtils::FormatErrorMessage( 229 ErrorUtils::FormatErrorMessage(
229 errors::kInvalidWebURL, 230 errors::kInvalidWebURL,
230 base::IntToString(0), 231 base::IntToString(0),
231 errors::kNoWildCardsInPaths)), 232 errors::kNoWildCardsInPaths)),
232 Testcase("web_urls_invalid_4.json", 233 Testcase("web_urls_invalid_4.json",
233 ExtensionErrorUtils::FormatErrorMessage( 234 ErrorUtils::FormatErrorMessage(
234 errors::kInvalidWebURL, 235 errors::kInvalidWebURL,
235 base::IntToString(0), 236 base::IntToString(0),
236 errors::kCannotClaimAllURLsInExtent)), 237 errors::kCannotClaimAllURLsInExtent)),
237 Testcase("web_urls_invalid_5.json", 238 Testcase("web_urls_invalid_5.json",
238 ExtensionErrorUtils::FormatErrorMessage( 239 ErrorUtils::FormatErrorMessage(
239 errors::kInvalidWebURL, 240 errors::kInvalidWebURL,
240 base::IntToString(1), 241 base::IntToString(1),
241 errors::kCannotClaimAllHostsInExtent)) 242 errors::kCannotClaimAllHostsInExtent))
242 }; 243 };
243 RunTestcases(testcases, arraysize(testcases), 244 RunTestcases(testcases, arraysize(testcases),
244 EXPECT_TYPE_ERROR); 245 EXPECT_TYPE_ERROR);
245 246
246 LoadAndExpectSuccess("web_urls_has_port.json"); 247 LoadAndExpectSuccess("web_urls_has_port.json");
247 248
248 scoped_refptr<Extension> extension( 249 scoped_refptr<Extension> extension(
249 LoadAndExpectSuccess("web_urls_default.json")); 250 LoadAndExpectSuccess("web_urls_default.json"));
250 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 251 ASSERT_EQ(1u, extension->web_extent().patterns().size());
251 EXPECT_EQ("*://www.google.com/*", 252 EXPECT_EQ("*://www.google.com/*",
252 extension->web_extent().patterns().begin()->GetAsString()); 253 extension->web_extent().patterns().begin()->GetAsString());
253 } 254 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698