Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc

Issue 11312228: Move extension_error_utils.* and url_pattern_set.* into (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hate Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "chrome/common/extensions/extension_error_utils.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h" 7 #include "chrome/common/extensions/extension_manifest_constants.h"
8 #include "extensions/common/error_utils.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace errors = extension_manifest_errors; 11 namespace errors = extension_manifest_errors;
12 12
13 using extensions::ErrorUtils;
14
13 TEST_F(ExtensionManifestTest, RequirementsInvalid) { 15 TEST_F(ExtensionManifestTest, RequirementsInvalid) {
14 Testcase testcases[] = { 16 Testcase testcases[] = {
15 Testcase("requirements_invalid_requirements.json", 17 Testcase("requirements_invalid_requirements.json",
16 errors::kInvalidRequirements), 18 errors::kInvalidRequirements),
17 Testcase("requirements_invalid_keys.json", errors::kInvalidRequirements), 19 Testcase("requirements_invalid_keys.json", errors::kInvalidRequirements),
18 Testcase("requirements_invalid_3d.json", 20 Testcase("requirements_invalid_3d.json",
19 ExtensionErrorUtils::FormatErrorMessage( 21 ErrorUtils::FormatErrorMessage(
20 errors::kInvalidRequirement, "3D")), 22 errors::kInvalidRequirement, "3D")),
21 Testcase("requirements_invalid_3d_features.json", 23 Testcase("requirements_invalid_3d_features.json",
22 ExtensionErrorUtils::FormatErrorMessage( 24 ErrorUtils::FormatErrorMessage(
23 errors::kInvalidRequirement, "3D")), 25 errors::kInvalidRequirement, "3D")),
24 Testcase("requirements_invalid_3d_features_value.json", 26 Testcase("requirements_invalid_3d_features_value.json",
25 ExtensionErrorUtils::FormatErrorMessage( 27 ErrorUtils::FormatErrorMessage(
26 errors::kInvalidRequirement, "3D")), 28 errors::kInvalidRequirement, "3D")),
27 Testcase("requirements_invalid_3d_no_features.json", 29 Testcase("requirements_invalid_3d_no_features.json",
28 ExtensionErrorUtils::FormatErrorMessage( 30 ErrorUtils::FormatErrorMessage(
29 errors::kInvalidRequirement, "3D")), 31 errors::kInvalidRequirement, "3D")),
30 Testcase("requirements_invalid_plugins.json", 32 Testcase("requirements_invalid_plugins.json",
31 ExtensionErrorUtils::FormatErrorMessage( 33 ErrorUtils::FormatErrorMessage(
32 errors::kInvalidRequirement, "plugins")), 34 errors::kInvalidRequirement, "plugins")),
33 Testcase("requirements_invalid_plugins_key.json", 35 Testcase("requirements_invalid_plugins_key.json",
34 ExtensionErrorUtils::FormatErrorMessage( 36 ErrorUtils::FormatErrorMessage(
35 errors::kInvalidRequirement, "plugins")), 37 errors::kInvalidRequirement, "plugins")),
36 Testcase("requirements_invalid_plugins_value.json", 38 Testcase("requirements_invalid_plugins_value.json",
37 ExtensionErrorUtils::FormatErrorMessage( 39 ErrorUtils::FormatErrorMessage(
38 errors::kInvalidRequirement, "plugins")) 40 errors::kInvalidRequirement, "plugins"))
39 }; 41 };
40 42
41 RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR); 43 RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
42 } 44 }
43 45
44 TEST_F(ExtensionManifestTest, RequirementsValid) { 46 TEST_F(ExtensionManifestTest, RequirementsValid) {
45 // Test the defaults. 47 // Test the defaults.
46 scoped_refptr<extensions::Extension> extension(LoadAndExpectSuccess( 48 scoped_refptr<extensions::Extension> extension(LoadAndExpectSuccess(
47 "requirements_valid_empty.json")); 49 "requirements_valid_empty.json"));
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 EXPECT_EQ(extension->requirements().webgl, false); 82 EXPECT_EQ(extension->requirements().webgl, false);
81 EXPECT_EQ(extension->requirements().css3d, false); 83 EXPECT_EQ(extension->requirements().css3d, false);
82 EXPECT_EQ(extension->requirements().npapi, false); 84 EXPECT_EQ(extension->requirements().npapi, false);
83 85
84 extension = LoadAndExpectSuccess("requirements_npapi_plugins_empty.json"); 86 extension = LoadAndExpectSuccess("requirements_npapi_plugins_empty.json");
85 ASSERT_TRUE(extension.get()); 87 ASSERT_TRUE(extension.get());
86 EXPECT_EQ(extension->requirements().webgl, false); 88 EXPECT_EQ(extension->requirements().webgl, false);
87 EXPECT_EQ(extension->requirements().css3d, false); 89 EXPECT_EQ(extension->requirements().css3d, false);
88 EXPECT_EQ(extension->requirements().npapi, true); 90 EXPECT_EQ(extension->requirements().npapi, true);
89 } 91 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698