Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 11312228: Move extension_error_utils.* and url_pattern_set.* into (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hate Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc
index c5a4f982624e2b0423fb4cad81755d178c15bcbc..12ab0ddd1d1f4eadfde427036a96e48334614735 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc
@@ -28,7 +28,6 @@
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/api/debugger.h"
#include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_error_utils.h"
#include "content/public/browser/devtools_agent_host_registry.h"
#include "content/public/browser/devtools_client_host.h"
#include "content/public/browser/devtools_manager.h"
@@ -37,6 +36,7 @@
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_client.h"
+#include "extensions/common/error_utils.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
#include "webkit/glue/webkit_glue.h"
@@ -47,6 +47,7 @@ using content::DevToolsClientHost;
using content::DevToolsManager;
using content::WebContents;
using extensions::api::debugger::Debuggee;
+using extensions::ErrorUtils;
namespace keys = debugger_api_constants;
namespace Attach = extensions::api::debugger::Attach;
@@ -408,7 +409,7 @@ bool DebuggerFunction::InitWebContents() {
bool result = ExtensionTabUtil::GetTabById(
tab_id_, profile(), include_incognito(), NULL, NULL, &web_contents, NULL);
if (!result || !web_contents) {
- error_ = ExtensionErrorUtils::FormatErrorMessage(
+ error_ = ErrorUtils::FormatErrorMessage(
keys::kNoTabError,
base::IntToString(tab_id_));
return false;
@@ -417,7 +418,7 @@ bool DebuggerFunction::InitWebContents() {
if (content::GetContentClient()->HasWebUIScheme(
contents_->GetURL())) {
- error_ = ExtensionErrorUtils::FormatErrorMessage(
+ error_ = ErrorUtils::FormatErrorMessage(
keys::kAttachToWebUIError,
contents_->GetURL().scheme());
return false;
@@ -436,7 +437,7 @@ bool DebuggerFunction::InitClientHost() {
if (!client_host_ ||
!client_host_->MatchesContentsAndExtensionId(contents_,
GetExtension()->id())) {
- error_ = ExtensionErrorUtils::FormatErrorMessage(
+ error_ = ErrorUtils::FormatErrorMessage(
keys::kNotAttachedError,
base::IntToString(tab_id_));
return false;
@@ -458,7 +459,7 @@ bool AttachDebuggerFunction::RunImpl() {
if (!webkit_glue::IsInspectorProtocolVersionSupported(
params->required_version)) {
- error_ = ExtensionErrorUtils::FormatErrorMessage(
+ error_ = ErrorUtils::FormatErrorMessage(
keys::kProtocolVersionNotSupportedError,
params->required_version);
return false;
@@ -470,7 +471,7 @@ bool AttachDebuggerFunction::RunImpl() {
GetDevToolsClientHostFor(agent);
if (client_host != NULL) {
- error_ = ExtensionErrorUtils::FormatErrorMessage(
+ error_ = ErrorUtils::FormatErrorMessage(
keys::kAlreadyAttachedError,
base::IntToString(tab_id_));
return false;

Powered by Google App Engine
This is Rietveld 408576698