Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_filebrowser_unittest.cc

Issue 11312228: Move extension_error_utils.* and url_pattern_set.* into (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hate Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "base/string_number_conversions.h" 7 #include "base/string_number_conversions.h"
8 #include "chrome/common/extensions/extension.h" 8 #include "chrome/common/extensions/extension.h"
9 #include "chrome/common/extensions/extension_error_utils.h"
10 #include "chrome/common/extensions/extension_manifest_constants.h" 9 #include "chrome/common/extensions/extension_manifest_constants.h"
11 #include "chrome/common/extensions/file_browser_handler.h" 10 #include "chrome/common/extensions/file_browser_handler.h"
11 #include "extensions/common/error_utils.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 using extensions::ErrorUtils;
14 using extensions::Extension; 15 using extensions::Extension;
16 using extensions::URLPatternSet;
15 17
16 namespace errors = extension_manifest_errors; 18 namespace errors = extension_manifest_errors;
17 19
18 TEST_F(ExtensionManifestTest, FileBrowserHandlers) { 20 TEST_F(ExtensionManifestTest, FileBrowserHandlers) {
19 Testcase testcases[] = { 21 Testcase testcases[] = {
20 Testcase("filebrowser_invalid_access_permission.json", 22 Testcase("filebrowser_invalid_access_permission.json",
21 ExtensionErrorUtils::FormatErrorMessage( 23 ErrorUtils::FormatErrorMessage(
22 errors::kInvalidFileAccessValue, base::IntToString(1))), 24 errors::kInvalidFileAccessValue, base::IntToString(1))),
23 Testcase("filebrowser_invalid_access_permission_list.json", 25 Testcase("filebrowser_invalid_access_permission_list.json",
24 errors::kInvalidFileAccessList), 26 errors::kInvalidFileAccessList),
25 Testcase("filebrowser_invalid_empty_access_permission_list.json", 27 Testcase("filebrowser_invalid_empty_access_permission_list.json",
26 errors::kInvalidFileAccessList), 28 errors::kInvalidFileAccessList),
27 Testcase("filebrowser_invalid_actions_1.json", 29 Testcase("filebrowser_invalid_actions_1.json",
28 errors::kInvalidFileBrowserHandler), 30 errors::kInvalidFileBrowserHandler),
29 Testcase("filebrowser_invalid_actions_2.json", 31 Testcase("filebrowser_invalid_actions_2.json",
30 errors::kInvalidFileBrowserHandler), 32 errors::kInvalidFileBrowserHandler),
31 Testcase("filebrowser_invalid_action_id.json", 33 Testcase("filebrowser_invalid_action_id.json",
32 errors::kInvalidPageActionId), 34 errors::kInvalidPageActionId),
33 Testcase("filebrowser_invalid_action_title.json", 35 Testcase("filebrowser_invalid_action_title.json",
34 errors::kInvalidPageActionDefaultTitle), 36 errors::kInvalidPageActionDefaultTitle),
35 Testcase("filebrowser_invalid_file_filters_1.json", 37 Testcase("filebrowser_invalid_file_filters_1.json",
36 errors::kInvalidFileFiltersList), 38 errors::kInvalidFileFiltersList),
37 Testcase("filebrowser_invalid_file_filters_2.json", 39 Testcase("filebrowser_invalid_file_filters_2.json",
38 ExtensionErrorUtils::FormatErrorMessage( 40 ErrorUtils::FormatErrorMessage(
39 errors::kInvalidFileFilterValue, base::IntToString(0))), 41 errors::kInvalidFileFilterValue, base::IntToString(0))),
40 Testcase("filebrowser_invalid_file_filters_url.json", 42 Testcase("filebrowser_invalid_file_filters_url.json",
41 ExtensionErrorUtils::FormatErrorMessage( 43 ErrorUtils::FormatErrorMessage(
42 errors::kInvalidURLPatternError, "http:*.html")) 44 errors::kInvalidURLPatternError, "http:*.html"))
43 }; 45 };
44 RunTestcases(testcases, arraysize(testcases), 46 RunTestcases(testcases, arraysize(testcases),
45 EXPECT_TYPE_ERROR); 47 EXPECT_TYPE_ERROR);
46 48
47 scoped_refptr<Extension> extension( 49 scoped_refptr<Extension> extension(
48 LoadAndExpectSuccess("filebrowser_valid.json")); 50 LoadAndExpectSuccess("filebrowser_valid.json"));
49 ASSERT_TRUE(extension.get()); 51 ASSERT_TRUE(extension.get());
50 ASSERT_TRUE(extension->file_browser_handlers() != NULL); 52 ASSERT_TRUE(extension->file_browser_handlers() != NULL);
51 ASSERT_EQ(extension->file_browser_handlers()->size(), 1U); 53 ASSERT_EQ(extension->file_browser_handlers()->size(), 1U);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 #if defined(FILE_MANAGER_EXTENSION) 86 #if defined(FILE_MANAGER_EXTENSION)
85 EXPECT_EQ("", error); 87 EXPECT_EQ("", error);
86 #else 88 #else
87 EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error); 89 EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error);
88 #endif 90 #endif
89 91
90 // Extensions of other types can't ovverride chrome://files/ URL. 92 // Extensions of other types can't ovverride chrome://files/ URL.
91 LoadAndExpectError("filebrowser_url_override.json", 93 LoadAndExpectError("filebrowser_url_override.json",
92 errors::kInvalidChromeURLOverrides); 94 errors::kInvalidChromeURLOverrides);
93 } 95 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698