Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1128163007: Fix missing GN dependencies. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, samuong+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stgao, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing GN dependencies. Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency. json_schema_api.gni was generating wrong names, this was fixed. mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency. The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents. BUG=487897 Committed: https://crrev.com/eadea21096be21b0d74c93f5b1a0ae6a9cc057d7 Cr-Commit-Position: refs/heads/master@{#330636}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Try without mojo #

Total comments: 1

Patch Set 4 : review comments, component build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -17 lines) Patch
M build/json_schema_api.gni View 2 chunks +6 lines, -4 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/BUILD.gn View 6 chunks +19 lines, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gin/BUILD.gn View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/mojo_application_package.gni View 3 1 chunk +7 lines, -2 lines 0 comments Download
M ui/resources/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
brettw
5 years, 7 months ago (2015-05-18 23:54:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128163007/20001
5 years, 7 months ago (2015-05-18 23:54:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/73339)
5 years, 7 months ago (2015-05-19 00:29:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128163007/20001
5 years, 7 months ago (2015-05-19 17:52:12 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-19 17:52:15 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128163007/40001
5 years, 7 months ago (2015-05-19 19:22:33 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/73605)
5 years, 7 months ago (2015-05-19 19:49:37 UTC) #14
Dirk Pranke
lgtm https://codereview.chromium.org/1128163007/diff/40001/build/secondary/tools/grit/grit_rule.gni File build/secondary/tools/grit/grit_rule.gni (right): https://codereview.chromium.org/1128163007/diff/40001/build/secondary/tools/grit/grit_rule.gni#newcode449 build/secondary/tools/grit/grit_rule.gni:449: # target rather than this library. This needs ...
5 years, 7 months ago (2015-05-19 19:59:22 UTC) #15
Dirk Pranke
oh, might also be a good idea to link to bug 487897 for context.
5 years, 7 months ago (2015-05-19 20:00:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128163007/60001
5 years, 7 months ago (2015-05-19 22:02:49 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-19 22:32:09 UTC) #20
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/eadea21096be21b0d74c93f5b1a0ae6a9cc057d7 Cr-Commit-Position: refs/heads/master@{#330636}
5 years, 7 months ago (2015-05-19 22:32:53 UTC) #21
brettw
5 years, 7 months ago (2015-05-19 23:12:01 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1137693006/ by brettw@chromium.org.

The reason for reverting is: Broke Windows:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1568/....

Powered by Google App Engine
This is Rietveld 408576698