Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3624)

Unified Diff: chrome/BUILD.gn

Issue 1128163007: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments, component build fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/secondary/tools/grit/grit_rule.gni ('k') | chrome/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 4f962b7902bf2b70326a22a79bc469c993d61f14..6ece001fc97cf5926f3ac95929eecb79d0656a90 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -535,6 +535,11 @@ repack("packed_extra_resources") {
"$root_gen_dir/content/browser/tracing/tracing_resources.pak",
"$root_gen_dir/content/content_resources.pak",
]
+ deps += [
+ "//content:resources",
+ "//content/browser/tracing:resources",
+ "//third_party/WebKit/public:resources",
+ ]
}
if (is_chromeos) {
sources += [ "$root_gen_dir/ui/file_manager/file_manager_resources.pak" ]
@@ -548,7 +553,10 @@ repack("packed_extra_resources") {
"$root_gen_dir/extensions/extensions_renderer_resources.pak",
"$root_gen_dir/extensions/extensions_resources.pak",
]
- deps += [ "//chrome/common:extensions_api_resources" ]
+ deps += [
+ "//chrome/common:extensions_api_resources",
+ "//extensions:extensions_resources",
+ ]
}
# GYP outputs the file in the gen/repack directory. On non-Mac/iOS platforms
@@ -567,6 +575,9 @@ repack("browser_tests_pak") {
"$root_gen_dir/chrome/options_test_resources.pak",
]
output = "$root_out_dir/browser_tests.pak"
+ deps = [
+ "//chrome/browser/resources:options_test_resources",
+ ]
}
# Collects per-locale grit files from many sources into global per-locale files.
@@ -629,8 +640,10 @@ template("chrome_repack_percent") {
deps = [
"//chrome/app/theme:theme_resources",
"//chrome/renderer:resources",
+ "//components/resources",
"//components/strings",
"//net:net_resources",
+ "//ui/resources",
]
if (!is_ios) {
@@ -638,7 +651,10 @@ template("chrome_repack_percent") {
"$root_gen_dir/blink/public/resources/blink_image_resources_${percent}_percent.pak",
"$root_gen_dir/content/app/resources/content_resources_${percent}_percent.pak",
]
- deps += [ "//content:resources" ]
+ deps += [
+ "//content/app/resources",
+ "//third_party/WebKit/public:image_resources",
+ ]
}
if (use_ash) {
sources +=
@@ -651,6 +667,7 @@ template("chrome_repack_percent") {
}
if (enable_extensions) {
sources += [ "$root_gen_dir/extensions/extensions_browser_resources_${percent}_percent.pak" ]
+ deps += [ "//extensions:extensions_browser_resources" ]
}
output = repack_output_file
« no previous file with comments | « build/secondary/tools/grit/grit_rule.gni ('k') | chrome/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698