Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: build/secondary/tools/grit/grit_rule.gni

Issue 1128163007: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try without mojo Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/json_schema_api.gni ('k') | chrome/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Instantiate grit. This will produce a script target to run grit, and a 5 # Instantiate grit. This will produce a script target to run grit, and a
6 # static library that compiles the .cc files. 6 # static library that compiles the .cc files.
7 # 7 #
8 # Parameters 8 # Parameters
9 # 9 #
10 # source (required) 10 # source (required)
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 } 439 }
440 440
441 # This is the thing that people actually link with, it must be named the 441 # This is the thing that people actually link with, it must be named the
442 # same as the argument the template was invoked with. 442 # same as the argument the template was invoked with.
443 source_set(target_name) { 443 source_set(target_name) {
444 # Since we generate a file, we need to be run before the targets that 444 # Since we generate a file, we need to be run before the targets that
445 # depend on us. 445 # depend on us.
446 sources = grit_outputs 446 sources = grit_outputs
447 447
448 # Deps set on the template invocation will go on the grit script running 448 # Deps set on the template invocation will go on the grit script running
449 # target rather than this library. 449 # target rather than this library. This needs to be a public deps so
Dirk Pranke 2015/05/19 19:59:22 nits .. what's a "grit script running target"? the
450 deps = [ 450 # other scripts can take the outputs from the grit script as inputs.
451 public_deps = [
451 ":$grit_custom_target", 452 ":$grit_custom_target",
452 ] 453 ]
453 public_configs = [ ":$grit_config" ] 454 public_configs = [ ":$grit_config" ]
454 455
455 if (defined(invoker.public_configs)) { 456 if (defined(invoker.public_configs)) {
456 public_configs += invoker.public_configs 457 public_configs += invoker.public_configs
457 } 458 }
458 459
459 if (defined(invoker.configs)) { 460 if (defined(invoker.configs)) {
460 configs += invoker.configs 461 configs += invoker.configs
461 } 462 }
462 463
463 if (defined(invoker.visibility)) { 464 if (defined(invoker.visibility)) {
464 visibility = invoker.visibility 465 visibility = invoker.visibility
465 } 466 }
466 output_name = grit_output_name 467 output_name = grit_output_name
467 } 468 }
468 } 469 }
OLDNEW
« no previous file with comments | « build/json_schema_api.gni ('k') | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698