extensions/BUILD.gn - Issue 1128163007: Fix missing GN dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/BUILD.gn

Issue 1128163007: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments, component build fix Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/BUILD.gn

diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn

index 8cfaea5301d49822823a8a67e1ce73acb51ccf57..e0cf7a1798324e2c4ea7abfc8987675f91a149a4 100644

--- a/extensions/BUILD.gn

+++ b/extensions/BUILD.gn

@@ -120,6 +120,7 @@ repack("shell_and_test_pak") {

deps = [

":extensions_resources",

"//content:resources",

+ "//content/app/strings",

"//content/browser/devtools:devtools_resources",

"//content/shell:resources",

"//extensions/shell:resources",

« no previous file with comments | « components/html_viewer/BUILD.gn ('k') | gin/BUILD.gn » ('j') | no next file with comments »