ui/resources/BUILD.gn - Issue 1128163007: Fix missing GN dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/resources/BUILD.gn

Issue 1128163007: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments, component build fix Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/resources/BUILD.gn

diff --git a/ui/resources/BUILD.gn b/ui/resources/BUILD.gn

index b81dd3a723527c757c07308bef6448fee7e4eef6..3dbd299135877a036cfb7872f33864c891370146 100644

--- a/ui/resources/BUILD.gn

+++ b/ui/resources/BUILD.gn

@@ -77,7 +77,7 @@ if (!is_mac) {

# (copy_ui_test_pak action)

if (is_ios || is_mac) {

group("ui_test_pak") {

- deps = [

+ public_deps = [

":repack_ui_test_pak",

":repack_ui_test_mac_locale_pack",

]

@@ -90,7 +90,7 @@ if (is_ios || is_mac) {

outputs = [

"$root_out_dir/ui/en-US.pak",

]

- deps = [

+ public_deps = [

":repack_ui_test_pak",

]

}

« no previous file with comments | « mojo/mojo_application_package.gni ('k') | no next file » | no next file with comments »