Issue 11266050: Rename regexp methods to getters.

Issue 11266050: Rename regexp methods to getters. (Closed)

Created:
8 years, 1 month ago by floitsch

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename regexp methods to getters. Committed: https://code.google.com/p/dart/source/detail?r=14094

Patch Set 2 : Rebase and update status files with co19 issue number. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -70 lines)			Patch
M	lib/compiler/implementation/dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View		1 chunk	+5 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/lib/string_helper.dart	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	lib/core/regexp.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/dartdoc/lib/src/markdown/inline_parser.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/intl/lib/bidi_utils.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/lib/regexp_patch.dart	View		2 chunks	+3 lines, -10 lines	0 comments	Download
M	runtime/lib/string_base.dart	View		5 chunks	+11 lines, -12 lines	0 comments	Download
M	samples/markdown/inline_parser.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	samples/third_party/dromaeo/common/BenchUtil.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	tests/corelib/reg_exp_start_end_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/corelib/string_pattern_test.dart	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/language/reg_ex2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/utils.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/template/codegen.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

Yes, please! LGTM https://codereview.chromium.org/11266050/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11266050/diff/1/tests/co19/co19-dart2dart.status#newcode95 tests/co19/co19-dart2dart.status:95: # The following test use methods ...

8 years, 1 month ago (2012-10-25 19:09:14 UTC) #2

floitsch

8 years, 1 month ago (2012-10-25 19:26:29 UTC) #3

https://codereview.chromium.org/11266050/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/11266050/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:95: # The following test use methods instead of
getters for regexps.
On 2012/10/25 19:09:14, Mads Ager wrote:
> Remem... I know you will! :-)

Done.

Expand Messages | Collapse Messages