Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: pkg/intl/lib/bidi_utils.dart

Issue 11266050: Rename regexp methods to getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase and update status files with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dartdoc/lib/src/markdown/inline_parser.dart ('k') | runtime/lib/regexp_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/bidi_utils.dart
diff --git a/pkg/intl/lib/bidi_utils.dart b/pkg/intl/lib/bidi_utils.dart
index 778f278ccce9d830e5a73144afcc5adb16582af0..e456c328dcf2ce6a0f7d1fa6de207743270dd025 100644
--- a/pkg/intl/lib/bidi_utils.dart
+++ b/pkg/intl/lib/bidi_utils.dart
@@ -243,8 +243,8 @@ class Bidi {
Match match = const RegExp('<\\w+').firstMatch(html);
if (match != null) {
buffer.add(html.substring(
- startIndex, match.end())).add(' dir=$direction');
- startIndex = match.end();
+ startIndex, match.end)).add(' dir=$direction');
+ startIndex = match.end;
}
return buffer.add(html.substring(startIndex)).toString();
}
@@ -296,9 +296,9 @@ class Bidi {
var startIndex = 0;
Iterable matches = regexp.allMatches(str);
for (Match match in matches) {
- buffer.add(str.substring(startIndex, match.start())).add(before);
- buffer.add(str.substring(match.start(), match.end())).add(after);
- startIndex = match.end();
+ buffer.add(str.substring(startIndex, match.start)).add(before);
+ buffer.add(str.substring(match.start, match.end)).add(after);
+ startIndex = match.end;
}
return buffer.add(str.substring(startIndex)).toString();
}
« no previous file with comments | « pkg/dartdoc/lib/src/markdown/inline_parser.dart ('k') | runtime/lib/regexp_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698