Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: lib/compiler/implementation/lib/coreimpl_patch.dart

Issue 11266050: Rename regexp methods to getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase and update status files with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/dart2js.dart ('k') | lib/compiler/implementation/lib/string_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/coreimpl_patch.dart
diff --git a/lib/compiler/implementation/lib/coreimpl_patch.dart b/lib/compiler/implementation/lib/coreimpl_patch.dart
index 15426f5ac160af90a1cd9c2821850beca8249b87..a8c0cebbc747a549b734713cab290a582e22f7bf 100644
--- a/lib/compiler/implementation/lib/coreimpl_patch.dart
+++ b/lib/compiler/implementation/lib/coreimpl_patch.dart
@@ -132,22 +132,20 @@ patch class JSSyntaxRegExp {
class _MatchImplementation implements Match {
final String pattern;
final String str;
- final int _start;
- final int _end;
+ final int start;
+ final int end;
final List<String> _groups;
const _MatchImplementation(
String this.pattern,
String this.str,
- int this._start,
- int this._end,
+ int this.start,
+ int this.end,
List<String> this._groups);
- int start() => _start;
- int end() => _end;
String group(int index) => _groups[index];
String operator [](int index) => group(index);
- int groupCount() => _groups.length - 1;
+ int get groupCount => _groups.length - 1;
List<String> groups(List<int> groups) {
List<String> out = [];
« no previous file with comments | « lib/compiler/implementation/dart2js.dart ('k') | lib/compiler/implementation/lib/string_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698