Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: utils/template/codegen.dart

Issue 11266050: Rename regexp methods to getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase and update status files with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/template/codegen.dart
diff --git a/utils/template/codegen.dart b/utils/template/codegen.dart
index 1fcc2f3836a07c08189af75337a7d0f9c3631b87..a622fba74456df5406663c3ff6308a30d4e49840 100644
--- a/utils/template/codegen.dart
+++ b/utils/template/codegen.dart
@@ -751,25 +751,25 @@ Nested #each or #with must have a localName;
int lastIdx = 0;
for (Match m in matches) {
- if (m.start() > lastIdx) {
- newExpr.add(expr.substring(lastIdx, m.start()));
+ if (m.start > lastIdx) {
+ newExpr.add(expr.substring(lastIdx, m.start));
}
bool identifier = true;
- if (m.start() > 0) {
- int charCode = expr.charCodeAt(m.start() - 1);
+ if (m.start > 0) {
+ int charCode = expr.charCodeAt(m.start - 1);
// Starts with ' or " then it's not an identifier.
identifier = charCode != 34 /* " */ && charCode != 39 /* ' */;
}
- String strMatch = expr.substring(m.start(), m.end());
+ String strMatch = expr.substring(m.start, m.end);
if (identifier) {
newExpr.add("${prefixPart}.${strMatch}");
} else {
// Quoted string don't touch.
newExpr.add("${strMatch}");
}
- lastIdx = m.end();
+ lastIdx = m.end;
}
if (expr.length > lastIdx) {
« no previous file with comments | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698