Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tests/corelib/string_pattern_test.dart

Issue 11266050: Rename regexp methods to getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase and update status files with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/corelib/reg_exp_start_end_test.dart ('k') | tests/language/reg_ex2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/string_pattern_test.dart
diff --git a/tests/corelib/string_pattern_test.dart b/tests/corelib/string_pattern_test.dart
index 88fc78c808b1e846c3a23b5cbae1be6945b5726f..440855d1b7882702fcf3c1d4b5048a675090cfb7 100644
--- a/tests/corelib/string_pattern_test.dart
+++ b/tests/corelib/string_pattern_test.dart
@@ -27,12 +27,12 @@ testOneMatch() {
var iterator = matches.iterator();
Match match = iterator.next();
Expect.isFalse(iterator.hasNext);
- Expect.equals(str.indexOf('with', 0), match.start());
- Expect.equals(str.indexOf('with', 0) + helloPattern.length, match.end());
+ Expect.equals(str.indexOf('with', 0), match.start);
+ Expect.equals(str.indexOf('with', 0) + helloPattern.length, match.end);
Expect.equals(helloPattern, match.pattern);
Expect.equals(str, match.str);
Expect.equals(helloPattern, match[0]);
- Expect.equals(0, match.groupCount());
+ Expect.equals(0, match.groupCount);
}
testTwoMatches() {
@@ -43,14 +43,14 @@ testTwoMatches() {
int start = 0;
for (var match in matches) {
count++;
- Expect.equals(str.indexOf('hello', start), match.start());
+ Expect.equals(str.indexOf('hello', start), match.start);
Expect.equals(
- str.indexOf('hello', start) + helloPattern.length, match.end());
+ str.indexOf('hello', start) + helloPattern.length, match.end);
Expect.equals(helloPattern, match.pattern);
Expect.equals(str, match.str);
Expect.equals(helloPattern, match[0]);
- Expect.equals(0, match.groupCount());
- start = match.end();
+ Expect.equals(0, match.groupCount);
+ start = match.end;
}
Expect.equals(2, count);
}
« no previous file with comments | « tests/corelib/reg_exp_start_end_test.dart ('k') | tests/language/reg_ex2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698