Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1126433002: Merge to XFA: Backfill some FX String/StringC unit tests for == and !=. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -2 lines) Patch
M core/include/fxcrt/fx_string.h View 2 chunks +8 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 2 chunks +222 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 2 chunks +223 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-05-02 00:03:43 UTC) #1
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-02 00:05:21 UTC) #2
Tom Sepez
5 years, 7 months ago (2015-05-02 00:07:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0446b2db3666899f4780c14e1905e354ccaaa00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698