Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/src/fxcrt/fx_basic_bstring_unittest.cpp

Issue 1126433002: Merge to XFA: Backfill some FX String/StringC unit tests for == and !=. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/include/fxcrt/fx_string.h ('k') | core/src/fxcrt/fx_basic_wstring_unittest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcrt/fx_basic_bstring_unittest.cpp
diff --git a/core/src/fxcrt/fx_basic_bstring_unittest.cpp b/core/src/fxcrt/fx_basic_bstring_unittest.cpp
index 57cfc8047ee2f67fa82f064327acd2e5bf93c521..7259c97b1f03430a3695ed80278b7465836dbc9d 100644
--- a/core/src/fxcrt/fx_basic_bstring_unittest.cpp
+++ b/core/src/fxcrt/fx_basic_bstring_unittest.cpp
@@ -45,6 +45,114 @@ TEST(fxcrt, ByteStringOperatorLT) {
EXPECT_FALSE(def < abc);
}
+TEST(fxcrt, ByteStringOperatorEQ) {
+ CFX_ByteString byte_string("hello");
+ ASSERT_TRUE(byte_string == byte_string);
+
+ CFX_ByteString byte_string_same1("hello");
+ ASSERT_TRUE(byte_string == byte_string_same1);
+ ASSERT_TRUE(byte_string_same1 == byte_string);
+
+ CFX_ByteString byte_string_same2(byte_string);
+ ASSERT_TRUE(byte_string == byte_string_same2);
+ ASSERT_TRUE(byte_string_same2 == byte_string);
+
+ CFX_ByteString byte_string1("he");
+ CFX_ByteString byte_string2("hellp");
+ CFX_ByteString byte_string3("hellod");
+ ASSERT_FALSE(byte_string == byte_string1);
+ ASSERT_FALSE(byte_string == byte_string2);
+ ASSERT_FALSE(byte_string == byte_string3);
+ ASSERT_FALSE(byte_string1 == byte_string);
+ ASSERT_FALSE(byte_string2 == byte_string);
+ ASSERT_FALSE(byte_string3 == byte_string);
+
+ CFX_ByteStringC byte_string_c_same1("hello");
+ ASSERT_TRUE(byte_string == byte_string_c_same1);
+ ASSERT_TRUE(byte_string_c_same1 == byte_string);
+
+ CFX_ByteStringC byte_string_c1("he");
+ CFX_ByteStringC byte_string_c2("hellp");
+ CFX_ByteStringC byte_string_c3("hellod");
+ ASSERT_FALSE(byte_string == byte_string_c1);
+ ASSERT_FALSE(byte_string == byte_string_c2);
+ ASSERT_FALSE(byte_string == byte_string_c3);
+ ASSERT_FALSE(byte_string_c1 == byte_string);
+ ASSERT_FALSE(byte_string_c2 == byte_string);
+ ASSERT_FALSE(byte_string_c3 == byte_string);
+
+ const char* c_string_same1 = "hello";
+ ASSERT_TRUE(byte_string == c_string_same1);
+#if 0
+ // TODO(tsepez): See, you don't want implicit c_str() casting.
+ // This degrades to a pointer comparision, which flunks.
+ ASSERT_TRUE(c_string_same1 == byte_string);
+#endif
+
+ const char* c_string1 = "he";
+ const char* c_string2 = "hellp";
+ const char* c_string3 = "hellod";
+ ASSERT_FALSE(byte_string == c_string1);
+ ASSERT_FALSE(byte_string == c_string2);
+ ASSERT_FALSE(byte_string == c_string3);
+ ASSERT_FALSE(c_string1 == byte_string);
+ ASSERT_FALSE(c_string2 == byte_string);
+ ASSERT_FALSE(c_string3 == byte_string);
+}
+
+TEST(fxcrt, ByteStringOperatorNE) {
+ CFX_ByteString byte_string("hello");
+ ASSERT_FALSE(byte_string != byte_string);
+
+ CFX_ByteString byte_string_same1("hello");
+ ASSERT_FALSE(byte_string != byte_string_same1);
+ ASSERT_FALSE(byte_string_same1 != byte_string);
+
+ CFX_ByteString byte_string_same2(byte_string);
+ ASSERT_FALSE(byte_string != byte_string_same2);
+ ASSERT_FALSE(byte_string_same2 != byte_string);
+
+ CFX_ByteString byte_string1("he");
+ CFX_ByteString byte_string2("hellp");
+ CFX_ByteString byte_string3("hellod");
+ ASSERT_TRUE(byte_string != byte_string1);
+ ASSERT_TRUE(byte_string != byte_string2);
+ ASSERT_TRUE(byte_string != byte_string3);
+ ASSERT_TRUE(byte_string1 != byte_string);
+ ASSERT_TRUE(byte_string2 != byte_string);
+ ASSERT_TRUE(byte_string3 != byte_string);
+
+ CFX_ByteStringC byte_string_c_same1("hello");
+ ASSERT_FALSE(byte_string != byte_string_c_same1);
+ ASSERT_FALSE(byte_string_c_same1 != byte_string);
+
+ CFX_ByteStringC byte_string_c1("he");
+ CFX_ByteStringC byte_string_c2("hellp");
+ CFX_ByteStringC byte_string_c3("hellod");
+ ASSERT_TRUE(byte_string != byte_string_c1);
+ ASSERT_TRUE(byte_string != byte_string_c2);
+ ASSERT_TRUE(byte_string != byte_string_c3);
+ ASSERT_TRUE(byte_string_c1 != byte_string);
+ ASSERT_TRUE(byte_string_c2 != byte_string);
+ ASSERT_TRUE(byte_string_c3 != byte_string);
+
+ const char* c_string_same1 = "hello";
+ ASSERT_FALSE(byte_string != c_string_same1);
+#if 0
+ // See above TODO.
+ ASSERT_FALSE(c_string_same1 != byte_string);
+#endif
+ const char* c_string1 = "he";
+ const char* c_string2 = "hellp";
+ const char* c_string3 = "hellod";
+ ASSERT_TRUE(byte_string != c_string1);
+ ASSERT_TRUE(byte_string != c_string2);
+ ASSERT_TRUE(byte_string != c_string3);
+ ASSERT_TRUE(c_string1 != byte_string);
+ ASSERT_TRUE(c_string2 != byte_string);
+ ASSERT_TRUE(c_string3 != byte_string);
+}
+
TEST(fxcrt, ByteStringCNull) {
CFX_ByteStringC null_string;
EXPECT_EQ(null_string.GetPtr(), nullptr);
@@ -268,3 +376,117 @@ TEST(fxcrt, ByteStringCOperatorLT) {
EXPECT_TRUE(abc < def);
EXPECT_FALSE(def < abc);
}
+
+TEST(fxcrt, ByteStringCOperatorEQ) {
+ CFX_ByteStringC byte_string_c("hello");
+ ASSERT_TRUE(byte_string_c == byte_string_c);
+
+ CFX_ByteStringC byte_string_c_same1("hello");
+ ASSERT_TRUE(byte_string_c == byte_string_c_same1);
+ ASSERT_TRUE(byte_string_c_same1 == byte_string_c);
+
+ CFX_ByteStringC byte_string_c_same2(byte_string_c);
+ ASSERT_TRUE(byte_string_c == byte_string_c_same2);
+ ASSERT_TRUE(byte_string_c_same2 == byte_string_c);
+
+ CFX_ByteStringC byte_string_c1("he");
+ CFX_ByteStringC byte_string_c2("hellp");
+ CFX_ByteStringC byte_string_c3("hellod");
+ ASSERT_FALSE(byte_string_c == byte_string_c1);
+ ASSERT_FALSE(byte_string_c == byte_string_c2);
+ ASSERT_FALSE(byte_string_c == byte_string_c3);
+ ASSERT_FALSE(byte_string_c1 == byte_string_c);
+ ASSERT_FALSE(byte_string_c2 == byte_string_c);
+ ASSERT_FALSE(byte_string_c3 == byte_string_c);
+
+ CFX_ByteString byte_string_same1("hello");
+ ASSERT_TRUE(byte_string_c == byte_string_same1);
+ ASSERT_TRUE(byte_string_same1 == byte_string_c);
+
+ CFX_ByteString byte_string1("he");
+ CFX_ByteString byte_string2("hellp");
+ CFX_ByteString byte_string3("hellod");
+ ASSERT_FALSE(byte_string_c == byte_string1);
+ ASSERT_FALSE(byte_string_c == byte_string2);
+ ASSERT_FALSE(byte_string_c == byte_string3);
+ ASSERT_FALSE(byte_string1 == byte_string_c);
+ ASSERT_FALSE(byte_string2 == byte_string_c);
+ ASSERT_FALSE(byte_string3 == byte_string_c);
+
+ const char* c_string_same1 = "hello";
+ ASSERT_TRUE(byte_string_c == c_string_same1);
+#if 0
+ // TODO(tsepez): missing operator (but no implicit cast to c_str).
+ ASSERT_TRUE(c_string_same1 == byte_string_c);
+#endif
+
+ const char* c_string1 = "he";
+ const char* c_string2 = "hellp";
+ const char* c_string3 = "hellod";
+ ASSERT_FALSE(byte_string_c == c_string1);
+ ASSERT_FALSE(byte_string_c == c_string2);
+ ASSERT_FALSE(byte_string_c == c_string3);
+#if 0
+ // See above TODO.
+ ASSERT_FALSE(c_string1 == byte_string_c);
+ ASSERT_FALSE(c_string2 == byte_string_c);
+ ASSERT_FALSE(c_string3 == byte_string_c);
+#endif
+}
+
+TEST(fxcrt, ByteStringCOperatorNE) {
+ CFX_ByteStringC byte_string_c("hello");
+ ASSERT_FALSE(byte_string_c != byte_string_c);
+
+ CFX_ByteStringC byte_string_c_same1("hello");
+ ASSERT_FALSE(byte_string_c != byte_string_c_same1);
+ ASSERT_FALSE(byte_string_c_same1 != byte_string_c);
+
+ CFX_ByteStringC byte_string_c_same2(byte_string_c);
+ ASSERT_FALSE(byte_string_c != byte_string_c_same2);
+ ASSERT_FALSE(byte_string_c_same2 != byte_string_c);
+
+ CFX_ByteStringC byte_string_c1("he");
+ CFX_ByteStringC byte_string_c2("hellp");
+ CFX_ByteStringC byte_string_c3("hellod");
+ ASSERT_TRUE(byte_string_c != byte_string_c1);
+ ASSERT_TRUE(byte_string_c != byte_string_c2);
+ ASSERT_TRUE(byte_string_c != byte_string_c3);
+ ASSERT_TRUE(byte_string_c1 != byte_string_c);
+ ASSERT_TRUE(byte_string_c2 != byte_string_c);
+ ASSERT_TRUE(byte_string_c3 != byte_string_c);
+
+ CFX_ByteString byte_string_same1("hello");
+ ASSERT_FALSE(byte_string_c != byte_string_same1);
+ ASSERT_FALSE(byte_string_same1 != byte_string_c);
+
+ CFX_ByteString byte_string1("he");
+ CFX_ByteString byte_string2("hellp");
+ CFX_ByteString byte_string3("hellod");
+ ASSERT_TRUE(byte_string_c != byte_string1);
+ ASSERT_TRUE(byte_string_c != byte_string2);
+ ASSERT_TRUE(byte_string_c != byte_string3);
+ ASSERT_TRUE(byte_string1 != byte_string_c);
+ ASSERT_TRUE(byte_string2 != byte_string_c);
+ ASSERT_TRUE(byte_string3 != byte_string_c);
+
+ const char* c_string_same1 = "hello";
+ ASSERT_FALSE(byte_string_c != c_string_same1);
+#if 0
+ // TODO(tsepez): missing operator (but no implicit cast to c_str).
+ ASSERT_FALSE(c_string_same1 != byte_string_c);
+#endif
+
+ const char* c_string1 = "he";
+ const char* c_string2 = "hellp";
+ const char* c_string3 = "hellod";
+ ASSERT_TRUE(byte_string_c != c_string1);
+ ASSERT_TRUE(byte_string_c != c_string2);
+ ASSERT_TRUE(byte_string_c != c_string3);
+#if 0
+ // See above TODO.
+ ASSERT_TRUE(c_string1 != byte_string_c);
+ ASSERT_TRUE(c_string2 != byte_string_c);
+ ASSERT_TRUE(c_string3 != byte_string_c);
+#endif
+}
« no previous file with comments | « core/include/fxcrt/fx_string.h ('k') | core/src/fxcrt/fx_basic_wstring_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698