Backfill some FX String unit tests for == and !=.

Backfill some FX String unit tests for == and !=.

... and there are a few inconsistencies which we can now fix. Also add a
comment about why these strings aren't headed for the dust-bin long term.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/dd0e99ba88d1697e41c8a8207313f93d0bd7fe7b

[Tom Sepez, 2015-05-01 20:03:53]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-05-01 20:11:01]

Lei, for review.  I think we need more coverage here, given how badly these
strings need modernization.

[Lei Zhang, 2015-05-01 21:50:38]

lgtm

https://codereview.chromium.org/1122573002/diff/40001/core/src/fxcrt/fx_basic...
File core/src/fxcrt/fx_basic_bstring_unittest.cpp (right):

https://codereview.chromium.org/1122573002/diff/40001/core/src/fxcrt/fx_basic...
core/src/fxcrt/fx_basic_bstring_unittest.cpp:49: CFX_ByteString
byteString("hello");
Can we name these byte_string and so on?

[Tom Sepez, 2015-05-01 22:58:41]

There ya go.

https://codereview.chromium.org/1122573002/diff/40001/core/src/fxcrt/fx_basic...
File core/src/fxcrt/fx_basic_bstring_unittest.cpp (right):

https://codereview.chromium.org/1122573002/diff/40001/core/src/fxcrt/fx_basic...
core/src/fxcrt/fx_basic_bstring_unittest.cpp:49: CFX_ByteString
byteString("hello");
On 2015/05/01 21:50:38, Lei Zhang wrote:
> Can we name these byte_string and so on?

Done.

[Tom Sepez, 2015-05-01 23:24:10]

Committed patchset #4 (id:60001) manually as
dd0e99ba88d1697e41c8a8207313f93d0bd7fe7b (presubmit successful).