Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: core/include/fxcrt/fx_string.h

Issue 1126433002: Merge to XFA: Backfill some FX String/StringC unit tests for == and !=. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/src/fxcrt/fx_basic_bstring_unittest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/include/fxcrt/fx_string.h
diff --git a/core/include/fxcrt/fx_string.h b/core/include/fxcrt/fx_string.h
index c98a77cfe144dc903bfd258586f4afb3dc68ac04..b4d7249209c481f25fc749d95eb4749d8d01d51c 100644
--- a/core/include/fxcrt/fx_string.h
+++ b/core/include/fxcrt/fx_string.h
@@ -182,7 +182,10 @@ struct CFX_StringData {
FX_STRSIZE m_nAllocLength;
FX_CHAR m_String[1];
};
-class CFX_ByteString
+
+// A mutable string with shared buffers using copy-on-write semantics that
+// avoids the cost of std::string's iterator stability guarantees.
+class CFX_ByteString
{
public:
typedef FX_CHAR value_type;
@@ -595,7 +598,10 @@ struct CFX_StringDataW {
FX_STRSIZE m_nAllocLength;
FX_WCHAR m_String[1];
};
-class CFX_WideString
+
+// A mutable string with shared buffers using copy-on-write semantics that
+// avoids the cost of std::string's iterator stability guarantees.
+class CFX_WideString
{
public:
typedef FX_WCHAR value_type;
« no previous file with comments | « no previous file | core/src/fxcrt/fx_basic_bstring_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698