Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1118973005: Backfill some FX StringC unit tests for == and !=. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Backfill some FX StringC unit tests for == and !=. Continuation of https://codereview.chromium.org/1122573002 Applies similar test to immutable versions of strings. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e09556b4e9049a6e46789d31da5eb0c203dd8580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -0 lines) Patch
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 chunk +114 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, same thing, different place.
5 years, 7 months ago (2015-05-01 23:40:09 UTC) #1
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-01 23:42:37 UTC) #2
Tom Sepez
5 years, 7 months ago (2015-05-01 23:55:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e09556b4e9049a6e46789d31da5eb0c203dd8580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698