Componentizes external_video_surface to reduce webview/Cast duplication.

Componentizes external_video_surface to reduce webview/Cast duplication.

R=boliu@chromium.org,qinmin@chromium.org,tedchoc@chromium.org,danakj@chromium.org,caitkp@chromium.org
BUG=484911
Committed: https://crrev.com/3ea31790faf24c410a330065cb953eab2ecf087d
Cr-Commit-Position: refs/heads/master@{#328859}

[gunsch, 2015-05-06 00:24:30]

gunsch@chromium.org changed reviewers:
+ caitkp@chromium.org
- blundell@chromium.org

[gunsch, 2015-05-06 00:26:42]

Patchset #1 (id:1) has been deleted

[gunsch, 2015-05-06 00:28:25]

Hi all,
 This should be a fairly mechanical change for the size of CL. The context is
simply that we have two copies of the same code and we only need one.

boliu/qinmin: are you okay being OWNERS of the new component?

caitkp: OWNERS for new component
danakj: OWNERS for new component's DEPS on ui/gfx/geometry
tedchoc: OWNERS for new component's DEPS on content/public/android

[boliu, 2015-05-06 00:43:16]

boliu@chromium.org changed reviewers:
+ wonsik@chromium.org, ycheo@chromium.org

[boliu, 2015-05-06 00:43:17]

LGTM!

I was going to make a comment about the test, but you moved it back in PS2 :)

On 2015/05/06 00:28:25, gunsch wrote:
> Hi all,
>  This should be a fairly mechanical change for the size of CL. The context is
> simply that we have two copies of the same code and we only need one.
> 
> boliu/qinmin: are you okay being OWNERS of the new component?

+ycheo/wonsik

Are you guys still actively working on chromium and maintaining this?

> 
> caitkp: OWNERS for new component
> danakj: OWNERS for new component's DEPS on ui/gfx/geometry
> tedchoc: OWNERS for new component's DEPS on content/public/android

[Ted C, 2015-05-06 00:47:31]

On 2015/05/06 00:28:25, gunsch wrote:
> Hi all,
>  This should be a fairly mechanical change for the size of CL. The context is
> simply that we have two copies of the same code and we only need one.
> 
> boliu/qinmin: are you okay being OWNERS of the new component?
> 
> caitkp: OWNERS for new component
> danakj: OWNERS for new component's DEPS on ui/gfx/geometry
> tedchoc: OWNERS for new component's DEPS on content/public/android

DEPS on content/public/android - lgtm

[Cait (Slow), 2015-05-06 22:04:39]

Please also add a BUILD.gn file for this new component.

[danakj, 2015-05-06 22:20:18]

ui/gfx/geometry DEPS LGTM

[gunsch, 2015-05-07 01:07:19]

Patchset #4 (id:80001) has been deleted

[gunsch, 2015-05-07 01:08:26]

@Cait: added a BUILD.gn. Note that neither of the consumers (Cast nor WebView)
currently can build using GN, however (I know Cast's is in progress, not sure
about WebView), so it's a bit of an orphan for now.

[qinmin, 2015-05-07 17:05:37]

lgtm

[Cait (Slow), 2015-05-07 17:09:02]

components/ lgtm

But please confirm that qinmin@ is ok with being an owner this new component
before landing the CL -- thanks!

[Cait (Slow), 2015-05-07 17:09:32]

On 2015/05/07 17:09:02, Cait wrote:
> components/ lgtm
> 
> But please confirm that qinmin@ is ok with being an owner this new component
> before landing the CL -- thanks!

...nvm :)

[gunsch, 2015-05-07 17:11:18]

The CQ bit was checked by gunsch@chromium.org to run a CQ dry run

[gunsch, 2015-05-07 17:11:19]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
boliu@chromium.org, tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1123993002/#ps100001
(title: "rebase, add BUILD.gn")

[boliu, 2015-05-07 17:11:34]

I guess all the peopple who originally pushed for VIDEO_HOLE and promised to
maintain it just let the project...

I'm ok owning the component.

[commit-bot: I haz the power, 2015-05-07 17:12:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123993002/100001

[commit-bot: I haz the power, 2015-05-07 18:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 18:25:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gunsch, 2015-05-07 18:37:01]

The CQ bit was checked by gunsch@chromium.org to run a CQ dry run

[gunsch, 2015-05-07 18:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
boliu@chromium.org, tedchoc@chromium.org, qinmin@chromium.org,
caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/1123993002/#ps120001
(title: "extra DEPS for Java-equivalent includes of native DEPS")

[commit-bot: I haz the power, 2015-05-07 18:40:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123993002/120001

[gunsch, 2015-05-07 21:02:55]

The CQ bit was checked by gunsch@chromium.org to run a CQ dry run

[gunsch, 2015-05-07 21:02:56]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
boliu@chromium.org, tedchoc@chromium.org, qinmin@chromium.org,
caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/1123993002/#ps140001
(title: "java DEPS, round 2")

[commit-bot: I haz the power, 2015-05-07 21:05:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123993002/140001

[commit-bot: I haz the power, 2015-05-07 21:57:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 21:57:13]

Dry run: This issue passed the CQ dry run.

[gunsch, 2015-05-07 22:13:23]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-05-07 22:14:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123993002/140001

[commit-bot: I haz the power, 2015-05-07 22:24:48]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2015-05-07 22:25:43]

Patchset 6 (id:??) landed as
https://crrev.com/3ea31790faf24c410a330065cb953eab2ecf087d
Cr-Commit-Position: refs/heads/master@{#328859}

[wonsik, 2015-05-08 02:07:41]

On 2015/05/06 00:43:17, boliu wrote:
> LGTM!
> 
> I was going to make a comment about the test, but you moved it back in PS2 :)
> 
> On 2015/05/06 00:28:25, gunsch wrote:
> > Hi all,
> >  This should be a fairly mechanical change for the size of CL. The context
is
> > simply that we have two copies of the same code and we only need one.
> > 
> > boliu/qinmin: are you okay being OWNERS of the new component?
> 
> +ycheo/wonsik
> 
> Are you guys still actively working on chromium and maintaining this?

I'm in a sort of passive maintenance mode --- I'm not actively working on
chromium these days.

> 
> > 
> > caitkp: OWNERS for new component
> > danakj: OWNERS for new component's DEPS on ui/gfx/geometry
> > tedchoc: OWNERS for new component's DEPS on content/public/android