components/external_video_surface/android/java/src/org/chromium/components/external_video_surface/ExternalVideoSurfaceContainer.java - Issue 1123993002: Componentizes external_video_surface to reduce webview/Cast duplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/external_video_surface/android/java/src/org/chromium/components/external_video_surface/ExternalVideoSurfaceContainer.java

Issue 1123993002: Componentizes external_video_surface to reduce webview/Cast duplication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: java DEPS, round 2 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/external_video_surface/OWNERS ('k') | components/external_video_surface/browser/android/external_video_surface_container_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/external_video_surface/android/java/src/org/chromium/components/external_video_surface/ExternalVideoSurfaceContainer.java

diff --git a/android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java b/components/external_video_surface/android/java/src/org/chromium/components/external_video_surface/ExternalVideoSurfaceContainer.java

similarity index 99%

rename from android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java

rename to components/external_video_surface/android/java/src/org/chromium/components/external_video_surface/ExternalVideoSurfaceContainer.java

index 45e7af75b58b1a383c74a1d478e39da323f0a251..baa2a6982f7832800ab01baedd72417e9ca54fb6 100644

--- a/android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java

+++ b/components/external_video_surface/android/java/src/org/chromium/components/external_video_surface/ExternalVideoSurfaceContainer.java

@@ -2,7 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-package org.chromium.android_webview;

+package org.chromium.components.external_video_surface;

import android.content.Context;

import android.graphics.Canvas;

@@ -20,7 +20,6 @@ import org.chromium.content.browser.RenderCoordinates;

import java.lang.ref.WeakReference;

-// TODO(gunsch): componentize this class.

/**

* This is a container for external video surfaces.

* The object is owned by the native peer and it is owned by WebContents.

@@ -39,7 +38,7 @@ import java.lang.ref.WeakReference;

* Please contact ycheo@chromium.org or wonsik@chromium.org if you have any

* questions or issues for this class.

-@JNINamespace("android_webview")

+@JNINamespace("external_video_surface")

public class ExternalVideoSurfaceContainer implements SurfaceHolder.Callback {

protected static final int INVALID_PLAYER_ID = -1;