Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: components/external_video_surface/browser/android/external_video_surface_container_impl.cc

Issue 1123993002: Componentizes external_video_surface to reduce webview/Cast duplication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: java DEPS, round 2 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/external_video_surface/browser/android/external_video_surface_container_impl.cc
diff --git a/android_webview/native/external_video_surface_container_impl.cc b/components/external_video_surface/browser/android/external_video_surface_container_impl.cc
similarity index 93%
rename from android_webview/native/external_video_surface_container_impl.cc
rename to components/external_video_surface/browser/android/external_video_surface_container_impl.cc
index 64270ef2ac99c8597dec8897bfb6d552e5c5866c..c707425366fbbb3d3e2b7bbc75bc4d2222400bdf 100644
--- a/android_webview/native/external_video_surface_container_impl.cc
+++ b/components/external_video_surface/browser/android/external_video_surface_container_impl.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "android_webview/native/external_video_surface_container_impl.h"
+#include "components/external_video_surface/browser/android/external_video_surface_container_impl.h"
#include "base/android/jni_android.h"
#include "content/public/browser/android/content_view_core.h"
@@ -12,7 +12,12 @@
using base::android::AttachCurrentThread;
using content::ContentViewCore;
-namespace android_webview {
+namespace external_video_surface {
+
+// static
+bool ExternalVideoSurfaceContainerImpl::RegisterJni(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
// static
ExternalVideoSurfaceContainerImpl* ExternalVideoSurfaceContainerImpl::Create(
@@ -105,8 +110,4 @@ void ExternalVideoSurfaceContainerImpl::SurfaceDestroyed(
surface_destroyed_cb_.Run(static_cast<int>(player_id));
}
-bool RegisterExternalVideoSurfaceContainer(JNIEnv* env) {
- return RegisterNativesImpl(env);
-}
-
-} // namespace android_webview
+} // namespace external_video_surface

Powered by Google App Engine
This is Rietveld 408576698