android_webview/native/external_video_surface_container_impl.h - Issue 1123993002: Componentizes external_video_surface to reduce webview/Cast duplication.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/native/external_video_surface_container_impl.h

Issue 1123993002: Componentizes external_video_surface to reduce webview/Cast duplication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: java DEPS, round 2 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « android_webview/native/android_webview_jni_registrar.cc ('k') | android_webview/native/external_video_surface_container_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #ifndef ANDROID_WEBVIEW_NATIVE_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_

6 #define ANDROID_WEBVIEW_NATIVE_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_

7

8 #include <jni.h>

9

10 #include "base/android/scoped_java_ref.h"

11 #include "base/callback.h"

12 #include "base/compiler_specific.h"

13 #include "content/public/browser/android/external_video_surface_container.h"

14

15 namespace android_webview {

16

17 class ExternalVideoSurfaceContainerImpl

18 : public content::ExternalVideoSurfaceContainer {

19 public:

20 typedef base::Callback<void(int, jobject)> SurfaceCreatedCB;

21 typedef base::Callback<void(int)> SurfaceDestroyedCB;

22

23 static ExternalVideoSurfaceContainerImpl* Create(

24 content::WebContents* web_contents);

25

26 // ExternalVideoSurfaceContainer implementation.

27 void RequestExternalVideoSurface(

28 int player_id,

29 const SurfaceCreatedCB& surface_created_cb,

30 const SurfaceDestroyedCB& surface_destroyed_cb) override;

31 int GetCurrentPlayerId() override;

32 void ReleaseExternalVideoSurface(int player_id) override;

33 void OnFrameInfoUpdated() override;

34 void OnExternalVideoSurfacePositionChanged(int player_id,

35 const gfx::RectF& rect) override;

36

37 // Methods called from Java.

38 void SurfaceCreated(

39 JNIEnv* env, jobject obj, jint player_id, jobject jsurface);

40 void SurfaceDestroyed(JNIEnv* env, jobject obj, jint player_id);

41

42 private:

43 explicit ExternalVideoSurfaceContainerImpl(

44 base::android::ScopedJavaLocalRef<jobject> java_content_view_core);

45 ~ExternalVideoSurfaceContainerImpl() override;

46

47 base::android::ScopedJavaGlobalRef<jobject> jobject_;

48

49 SurfaceCreatedCB surface_created_cb_;

50 SurfaceDestroyedCB surface_destroyed_cb_;

51

52 DISALLOW_COPY_AND_ASSIGN(ExternalVideoSurfaceContainerImpl);

53 };

54

55 bool RegisterExternalVideoSurfaceContainer(JNIEnv* env);

56

57 } // namespace android_webview

58

59 #endif // ANDROID_WEBVIEW_NATIVE_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_

OLD	NEW