android_webview/native/webview_native.gyp - Issue 1123993002: Componentizes external_video_surface to reduce webview/Cast duplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/webview_native.gyp

Issue 1123993002: Componentizes external_video_surface to reduce webview/Cast duplication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: java DEPS, round 2 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/webview_native.gyp

diff --git a/android_webview/native/webview_native.gyp b/android_webview/native/webview_native.gyp

index 960dc0f83224db76e2c4d4b32838d5d1f33ee73e..a7ab2e2ba5b0dd4ba4645611343b7e9a0bae2a7b 100644

--- a/android_webview/native/webview_native.gyp

+++ b/android_webview/native/webview_native.gyp

@@ -103,9 +103,8 @@

'conditions': [

['video_hole==1', {

- 'sources': [

- 'external_video_surface_container_impl.cc',

- 'external_video_surface_container_impl.h',

+ 'dependencies': [

+ '../../components/components.gyp:external_video_surface',

}],

@@ -142,7 +141,6 @@

'../java/src/org/chromium/android_webview/AwSettings.java',

'../java/src/org/chromium/android_webview/AwWebContentsDelegate.java',

'../java/src/org/chromium/android_webview/AwWebResourceResponse.java',

- '../java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java',

'../java/src/org/chromium/android_webview/InputStreamUtil.java',

'../java/src/org/chromium/android_webview/JavaBrowserViewRendererHelper.java',

'../java/src/org/chromium/android_webview/permission/AwPermissionRequest.java',

« no previous file with comments | « android_webview/native/external_video_surface_container_impl.cc ('k') | chromecast/android/DEPS » ('j') | no next file with comments »