cc: Switch to Chromium DCHECKs LOGs

cc: Switch to Chromium DCHECKs LOGs

We can't compile-guard code and use DCHECK since it can be enabled at runtime. So we guard the DCHECKs that we want to rely on conditionally-compiled code in !NDEBUG compile guards.

This also replaces use of LOG_ERROR("Foo") with LOG(ERROR)<<"Foo";

This was previously discussed and committed as https://codereview.chromium.org/11048044/
using a guard based on LOGGING_IS_OFFICIAL_BUILD, however this was not sufficient since there are build configurations that are official builds but have dchecks compiled.

R=enne

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162739

[danakj, 2012-10-17 15:59:29]

I also added a PRESUBMIT check for ASSERT() this time around.

[danakj, 2012-10-17 18:34:02]

Using NDEBUG and DCHECK. PTAL

[jamesr, 2012-10-17 18:51:51]

FYI, we have more specific DCHECK_ variants if you want - I tagged a few.  I'm
fine with just bulk-converting as-is and then migrating stuff to more specific
checks over time if that's how you wanna do it.

Deferring to enne for the actual review.

https://codereview.chromium.org/11192030/diff/1099/cc/animation_curve.cc
File cc/animation_curve.cc (right):

https://codereview.chromium.org/11192030/diff/1099/cc/animation_curve.cc#newc...
cc/animation_curve.cc:15: DCHECK(type() == CCAnimationCurve::Float);
DCHECK_EQ will print the two types if it fails

https://codereview.chromium.org/11192030/diff/1099/cc/caching_bitmap_canvas_l...
File cc/caching_bitmap_canvas_layer_texture_updater.cc (right):

https://codereview.chromium.org/11192030/diff/1099/cc/caching_bitmap_canvas_l...
cc/caching_bitmap_canvas_layer_texture_updater.cc:48:
DCHECK(new_bitmap.bytesPerPixel() > 0);
DCHECK_GT

https://codereview.chromium.org/11192030/diff/1099/cc/checkerboard_draw_quad.cc
File cc/checkerboard_draw_quad.cc (right):

https://codereview.chromium.org/11192030/diff/1099/cc/checkerboard_draw_quad....
cc/checkerboard_draw_quad.cc:26: DCHECK(quad->material() ==
CCDrawQuad::Checkerboard);
DCHECK_EQ

[danakj, 2012-10-17 18:54:53]

On Wed, Oct 17, 2012 at 2:51 PM,  <jamesr@chromium.org> wrote:
> FYI, we have more specific DCHECK_ variants if you want - I tagged a few.
> I'm
> fine with just bulk-converting as-is and then migrating stuff to more
> specific
> checks over time if that's how you wanna do it.

I started using those at first, but then some of our data types don't
support conversions to strings for operator<< and then they don't
compile. Also I realized I'd messed up some of the conversions (LT vs
LE etc). I'd prefer to make those changes in smaller CLs anyhow though
if we're going to use them, because it's so easy to mess up something
and miss it with so many files.

> Deferring to enne for the actual review.
>
>
> https://codereview.chromium.org/11192030/diff/1099/cc/animation_curve.cc
> File cc/animation_curve.cc (right):
>
>
https://codereview.chromium.org/11192030/diff/1099/cc/animation_curve.cc#newc...
> cc/animation_curve.cc:15: DCHECK(type() == CCAnimationCurve::Float);
> DCHECK_EQ will print the two types if it fails
>
>
https://codereview.chromium.org/11192030/diff/1099/cc/caching_bitmap_canvas_l...
> File cc/caching_bitmap_canvas_layer_texture_updater.cc (right):
>
>
https://codereview.chromium.org/11192030/diff/1099/cc/caching_bitmap_canvas_l...
> cc/caching_bitmap_canvas_layer_texture_updater.cc:48:
> DCHECK(new_bitmap.bytesPerPixel() > 0);
> DCHECK_GT
>
>
https://codereview.chromium.org/11192030/diff/1099/cc/checkerboard_draw_quad.cc
> File cc/checkerboard_draw_quad.cc (right):
>
>
https://codereview.chromium.org/11192030/diff/1099/cc/checkerboard_draw_quad....
> cc/checkerboard_draw_quad.cc:26: DCHECK(quad->material() ==
> CCDrawQuad::Checkerboard);
> DCHECK_EQ
>
> https://codereview.chromium.org/11192030/

[enne (OOO), 2012-10-17 21:08:03]

lgtm