Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Issue 11192030: cc: Switch to Chromium DCHECKs LOGs (Closed)

Created:
8 years, 2 months ago by danakj
Modified:
8 years, 2 months ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Switch to Chromium DCHECKs LOGs We can't compile-guard code and use DCHECK since it can be enabled at runtime. So we guard the DCHECKs that we want to rely on conditionally-compiled code in !NDEBUG compile guards. This also replaces use of LOG_ERROR("Foo") with LOG(ERROR)<<"Foo"; This was previously discussed and committed as https://codereview.chromium.org/11048044/ using a guard based on LOGGING_IS_OFFICIAL_BUILD, however this was not sufficient since there are build configurations that are official builds but have dchecks compiled. R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162739

Patch Set 1 #

Patch Set 2 : dcheck and ndebug #

Total comments: 3

Patch Set 3 : rebase #

Patch Set 4 : rebaseonjamesr #

Patch Set 5 : newasserts #

Patch Set 6 : rebaseonenne #

Unified diffs Side-by-side diffs Delta from patch set Stats (+741 lines, -640 lines) Patch
M cc/DEPS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cc/PRESUBMIT.py View 1 1 chunk +35 lines, -0 lines 0 comments Download
M cc/animation_curve.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M cc/caching_bitmap_canvas_layer_texture_updater.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/checkerboard_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/completion_event.h View 1 3 chunks +7 lines, -4 lines 0 comments Download
M cc/damage_tracker.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/debug_border_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/debug_rect_history.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/delay_based_time_source.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M cc/delegated_renderer_layer_impl.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download
M cc/direct_renderer.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/draw_quad.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M cc/font_atlas.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/frame_rate_controller.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M cc/frame_rate_counter.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/gl_renderer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/gl_renderer.cc View 1 2 3 32 chunks +41 lines, -44 lines 0 comments Download
M cc/gl_renderer_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/io_surface_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/keyframed_animation_curve.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layer.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M cc/layer_animation_controller.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M cc/layer_impl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/layer_impl.cc View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
M cc/layer_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_quad.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M cc/layer_sorter.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_texture_sub_image.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tiling_data.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M cc/layer_tree_host.cc View 1 2 3 13 chunks +17 lines, -17 lines 0 comments Download
M cc/layer_tree_host_common.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 2 3 4 5 20 chunks +28 lines, -28 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 1 2 3 4 5 6 chunks +6 lines, -6 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 1 2 3 4 5 8 chunks +9 lines, -9 lines 0 comments Download
M cc/math_util.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M cc/math_util.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/occlusion_tracker.cc View 1 5 chunks +12 lines, -12 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M cc/platform_color.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/prioritized_texture.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/prioritized_texture.cc View 1 8 chunks +20 lines, -20 lines 0 comments Download
M cc/prioritized_texture_manager.cc View 1 2 3 20 chunks +49 lines, -49 lines 0 comments Download
M cc/prioritized_texture_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/program_binding.h View 1 3 chunks +6 lines, -4 lines 0 comments Download
M cc/program_binding.cc View 1 2 3 6 chunks +10 lines, -11 lines 0 comments Download
M cc/proxy.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M cc/proxy.cc View 1 2 3 4 5 2 chunks +18 lines, -4 lines 0 comments Download
M cc/quad_culler.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/rate_limiter.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/render_pass.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/render_pass_draw_quad.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/render_surface_filters.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M cc/render_surface_impl.cc View 1 6 chunks +6 lines, -5 lines 0 comments Download
M cc/resource_provider.cc View 1 2 3 26 chunks +61 lines, -61 lines 0 comments Download
M cc/resource_provider_unittest.cc View 1 2 3 4 5 10 chunks +38 lines, -37 lines 0 comments Download
M cc/scheduler.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M cc/scheduler_state_machine.cc View 1 8 chunks +11 lines, -11 lines 0 comments Download
M cc/scheduler_unittest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M cc/scoped_ptr_deque.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
M cc/scoped_ptr_hash_map.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M cc/scoped_ptr_vector.h View 1 5 chunks +7 lines, -6 lines 0 comments Download
M cc/scoped_texture.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/scoped_texture.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M cc/scoped_thread_proxy.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M cc/scrollbar_layer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/shader.cc View 1 17 chunks +17 lines, -16 lines 0 comments Download
M cc/single_thread_proxy.h View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M cc/single_thread_proxy.cc View 1 2 3 4 5 14 chunks +24 lines, -24 lines 0 comments Download
M cc/software_renderer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/solid_color_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/stream_video_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/stubs/config.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/fake_web_compositor_output_surface.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M cc/test/fake_web_compositor_software_output_device.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/test/scheduler_test_common.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/scheduler_test_common.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/texture_copier.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/texture_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/texture_layer_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/texture_update_controller.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M cc/thread_proxy.cc View 1 2 3 4 5 40 chunks +70 lines, -70 lines 0 comments Download
M cc/threaded_unittest.cc View 1 2 3 4 5 11 chunks +12 lines, -12 lines 0 comments Download
M cc/throttled_texture_uploader.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/tile_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/tiled_layer.cc View 1 8 chunks +9 lines, -9 lines 0 comments Download
M cc/tiled_layer_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/timer.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/tree_synchronizer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/video_layer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/video_layer_impl.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
M cc/yuv_video_draw_quad.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
8 years, 2 months ago (2012-10-17 15:59:08 UTC) #1
danakj
I also added a PRESUBMIT check for ASSERT() this time around.
8 years, 2 months ago (2012-10-17 15:59:29 UTC) #2
danakj
Using NDEBUG and DCHECK. PTAL
8 years, 2 months ago (2012-10-17 18:34:02 UTC) #3
jamesr
FYI, we have more specific DCHECK_ variants if you want - I tagged a few. ...
8 years, 2 months ago (2012-10-17 18:51:51 UTC) #4
danakj
On Wed, Oct 17, 2012 at 2:51 PM, <jamesr@chromium.org> wrote: > FYI, we have more ...
8 years, 2 months ago (2012-10-17 18:54:53 UTC) #5
enne (OOO)
8 years, 2 months ago (2012-10-17 21:08:03 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698