Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1118643002: Replace v8::Handle with v8::Local in gin/modules/* (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace v8::Handle with v8::Local in gin/modules/* v8::Handle is an alias of v8::Local BUG=424445 Committed: https://crrev.com/41e8515a94e1a02f5852c76c50ed6a8c56fce514 Cr-Commit-Position: refs/heads/master@{#327683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M gin/modules/module_registry.h View 2 chunks +7 lines, -7 lines 0 comments Download
M gin/modules/module_registry.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M gin/modules/module_registry_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M gin/modules/module_runner_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M gin/modules/module_runner_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gin/modules/timer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gin/modules/timer.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-30 03:48:16 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-30 03:55:50 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-30 07:25:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118643002/1
5 years, 7 months ago (2015-04-30 07:26:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 08:13:05 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 08:14:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41e8515a94e1a02f5852c76c50ed6a8c56fce514
Cr-Commit-Position: refs/heads/master@{#327683}

Powered by Google App Engine
This is Rietveld 408576698