Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: gin/modules/timer.cc

Issue 1118643002: Replace v8::Handle with v8::Local in gin/modules/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/modules/timer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/timer.cc
diff --git a/gin/modules/timer.cc b/gin/modules/timer.cc
index 4ba7f9174e4563c5931b44ba3993a31ac8764b50..8aac8a6492560871bfb6c33ba57e30cf951f2224 100644
--- a/gin/modules/timer.cc
+++ b/gin/modules/timer.cc
@@ -12,7 +12,7 @@ namespace gin {
namespace {
-v8::Handle<v8::String> GetHiddenPropertyName(v8::Isolate* isolate) {
+v8::Local<v8::String> GetHiddenPropertyName(v8::Isolate* isolate) {
return gin::StringToSymbol(isolate, "::gin::Timer");
}
@@ -24,7 +24,7 @@ gin::WrapperInfo Timer::kWrapperInfo = { gin::kEmbedderNativeGin };
// static
Handle<Timer> Timer::Create(TimerType type, v8::Isolate* isolate, int delay_ms,
- v8::Handle<v8::Function> function) {
+ v8::Local<v8::Function> function) {
return CreateHandle(isolate, new Timer(isolate, type == TYPE_REPEATING,
delay_ms, function));
}
@@ -40,7 +40,7 @@ ObjectTemplateBuilder Timer::GetObjectTemplateBuilder(v8::Isolate* isolate) {
}
Timer::Timer(v8::Isolate* isolate, bool repeating, int delay_ms,
- v8::Handle<v8::Function> function)
+ v8::Local<v8::Function> function)
: timer_(false, repeating),
runner_(PerContextData::From(
isolate->GetCurrentContext())->runner()->GetWeakPtr()),
@@ -64,7 +64,7 @@ void Timer::OnTimerFired() {
Runner::Scope scope(runner_.get());
v8::Isolate* isolate = runner_->GetContextHolder()->isolate();
- v8::Handle<v8::Function> function = v8::Handle<v8::Function>::Cast(
+ v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(
GetWrapper(isolate)->GetHiddenValue(GetHiddenPropertyName(isolate)));
runner_->Call(function, v8::Undefined(isolate), 0, NULL);
}
« no previous file with comments | « gin/modules/timer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698