Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: gin/modules/module_registry_unittest.cc

Issue 1118643002: Replace v8::Handle with v8::Local in gin/modules/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/modules/module_registry.cc ('k') | gin/modules/module_runner_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/module_registry_unittest.cc
diff --git a/gin/modules/module_registry_unittest.cc b/gin/modules/module_registry_unittest.cc
index ed725fc8cb8d09addff1024c428363e0b67eac43..2d6e6daf83eb1eba0b76c5e93f2f2a1a4dea7db7 100644
--- a/gin/modules/module_registry_unittest.cc
+++ b/gin/modules/module_registry_unittest.cc
@@ -55,22 +55,22 @@ class ModuleRegistryObserverImpl : public ModuleRegistryObserver {
DISALLOW_COPY_AND_ASSIGN(ModuleRegistryObserverImpl);
};
-void NestedCallback(v8::Handle<v8::Value> value) {
+void NestedCallback(v8::Local<v8::Value> value) {
FAIL() << "Should not be called";
}
void OnModuleLoaded(TestHelper* helper,
v8::Isolate* isolate,
int64_t* counter,
- v8::Handle<v8::Value> value) {
+ v8::Local<v8::Value> value) {
ASSERT_TRUE(value->IsNumber());
- v8::Handle<v8::Integer> int_value = v8::Handle<v8::Integer>::Cast(value);
+ v8::Local<v8::Integer> int_value = v8::Local<v8::Integer>::Cast(value);
*counter += int_value->Value();
ModuleRegistry::From(helper->runner->GetContextHolder()->context())
->LoadModule(isolate, "two", base::Bind(NestedCallback));
}
-void OnModuleLoadedNoOp(v8::Handle<v8::Value> value) {
+void OnModuleLoadedNoOp(v8::Local<v8::Value> value) {
ASSERT_TRUE(value->IsNumber());
}
@@ -83,8 +83,8 @@ typedef V8Test ModuleRegistryTest;
TEST_F(ModuleRegistryTest, DestroyedWithContext) {
v8::Isolate::Scope isolate_scope(instance_->isolate());
v8::HandleScope handle_scope(instance_->isolate());
- v8::Handle<v8::Context> context = v8::Context::New(
- instance_->isolate(), NULL, v8::Handle<v8::ObjectTemplate>());
+ v8::Local<v8::Context> context = v8::Context::New(
+ instance_->isolate(), NULL, v8::Local<v8::ObjectTemplate>());
{
ContextHolder context_holder(instance_->isolate());
context_holder.SetContext(context);
« no previous file with comments | « gin/modules/module_registry.cc ('k') | gin/modules/module_runner_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698