gin/modules/module_runner_delegate.h - Issue 1118643002: Replace v8::Handle with v8::Local in gin/modules/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/module_runner_delegate.h

Issue 1118643002: Replace v8::Handle with v8::Local in gin/modules/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/module_runner_delegate.h

diff --git a/gin/modules/module_runner_delegate.h b/gin/modules/module_runner_delegate.h

index bd174f0822f491c278b0addbef759bc8eed337c4..002db1c7425c0dbd113631916e973fa67a7dbf62 100644

--- a/gin/modules/module_runner_delegate.h

+++ b/gin/modules/module_runner_delegate.h

@@ -39,7 +39,7 @@ class GIN_EXPORT ModuleRunnerDelegate : public ShellRunnerDelegate {

typedef std::map<std::string, ModuleGetterCallback> BuiltinModuleMap;

// From ShellRunnerDelegate:

- v8::Handle<v8::ObjectTemplate> GetGlobalTemplate(

+ v8::Local<v8::ObjectTemplate> GetGlobalTemplate(

ShellRunner* runner,

v8::Isolate* isolate) override;

void DidCreateContext(ShellRunner* runner) override;

« no previous file with comments | « gin/modules/module_registry_unittest.cc ('k') | gin/modules/module_runner_delegate.cc » ('j') | no next file with comments »