Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: gin/modules/module_registry.h

Issue 1118643002: Replace v8::Handle with v8::Local in gin/modules/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/modules/module_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/module_registry.h
diff --git a/gin/modules/module_registry.h b/gin/modules/module_registry.h
index 439207eaf3f51e6f6a590125567cc61c91904e46..c53155a44a4c78f717ac67ce7f79d218e7161ae5 100644
--- a/gin/modules/module_registry.h
+++ b/gin/modules/module_registry.h
@@ -36,25 +36,25 @@ struct PendingModule;
//
class GIN_EXPORT ModuleRegistry {
public:
- typedef base::Callback<void (v8::Handle<v8::Value>)> LoadModuleCallback;
+ typedef base::Callback<void (v8::Local<v8::Value>)> LoadModuleCallback;
virtual ~ModuleRegistry();
- static ModuleRegistry* From(v8::Handle<v8::Context> context);
+ static ModuleRegistry* From(v8::Local<v8::Context> context);
static void RegisterGlobals(v8::Isolate* isolate,
- v8::Handle<v8::ObjectTemplate> templ);
+ v8::Local<v8::ObjectTemplate> templ);
// Installs the necessary functions needed for modules.
// WARNING: this may execute script in the page.
- static void InstallGlobals(v8::Isolate* isolate, v8::Handle<v8::Object> obj);
+ static void InstallGlobals(v8::Isolate* isolate, v8::Local<v8::Object> obj);
void AddObserver(ModuleRegistryObserver* observer);
void RemoveObserver(ModuleRegistryObserver* observer);
// The caller must have already entered our context.
void AddBuiltinModule(v8::Isolate* isolate, const std::string& id,
- v8::Handle<v8::Value> module);
+ v8::Local<v8::Value> module);
// The caller must have already entered our context.
void AddPendingModule(v8::Isolate* isolate,
@@ -84,12 +84,12 @@ class GIN_EXPORT ModuleRegistry {
void Load(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
void RegisterModule(v8::Isolate* isolate,
const std::string& id,
- v8::Handle<v8::Value> module);
+ v8::Local<v8::Value> module);
bool CheckDependencies(PendingModule* pending);
bool AttemptToLoad(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
- v8::Handle<v8::Value> GetModule(v8::Isolate* isolate, const std::string& id);
+ v8::Local<v8::Value> GetModule(v8::Isolate* isolate, const std::string& id);
std::set<std::string> available_modules_;
std::set<std::string> unsatisfied_dependencies_;
« no previous file with comments | « no previous file | gin/modules/module_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698