Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1115533002: Build crash_service in Win GN builds. (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
Reviewers:
Mark Mentovai, scottmg
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build crash_service in Win GN builds. R=scottmg@chromium.org, mark@chromium.org BUG=354261 CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg,win_chromium_gn_x64_rel,win_chromium_gn_x64_dbg Committed: https://crrev.com/db5a56c70e825e9d7492b4e05827d315349ff23d Cr-Commit-Position: refs/heads/master@{#327521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M build/gn_migration.gypi View 2 chunks +1 line, -1 line 0 comments Download
M components/crash/tools/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
Dirk Pranke
5 years, 7 months ago (2015-04-29 02:27:51 UTC) #1
scottmg
lgtm
5 years, 7 months ago (2015-04-29 02:29:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115533002/1
5 years, 7 months ago (2015-04-29 02:31:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59779)
5 years, 7 months ago (2015-04-29 06:35:34 UTC) #8
Dirk Pranke
I'm surprised that Scott isn't an owner of this ... Mark, can I get an ...
5 years, 7 months ago (2015-04-29 15:25:28 UTC) #10
Mark Mentovai
LGTM, and Scott, you can also send me something to OWN this directory if you’d ...
5 years, 7 months ago (2015-04-29 17:55:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115533002/1
5 years, 7 months ago (2015-04-29 17:57:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 18:01:21 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:02:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db5a56c70e825e9d7492b4e05827d315349ff23d
Cr-Commit-Position: refs/heads/master@{#327521}

Powered by Google App Engine
This is Rietveld 408576698