Issue 1265793002: patch from petermayo to fix GN dependency regeneration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1265793002: patch from petermayo to fix GN dependency regeneration (Closed)

Created:
5 years, 4 months ago by Dirk Pranke

Modified:
5 years, 4 months ago

Reviewers:
Peter Mayo

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

patch from petermayo to fix GN dependency regeneration R=petermayo@chromium.org BUG=

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -13 lines)			Patch
M	tools/gn/function_write_file.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	tools/gn/ninja_build_writer.cc	View	1	3 chunks	+24 lines, -5 lines	0 comments	Download
M	tools/gn/scheduler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/scheduler.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Depends on Patchset:

Total messages: 5 (1 generated)

Peter Mayo

On 2015/07/30 22:13:37, Dirk Pranke wrote: Duplicate of https://codereview.chromium.org/1252403005/ ?

5 years, 4 months ago (2015-07-30 23:20:31 UTC) #3

Peter Mayo

On 2015/07/30 23:20:31, Peter Mayo wrote: > On 2015/07/30 22:13:37, Dirk Pranke wrote: > > ...

5 years, 4 months ago (2015-07-30 23:23:16 UTC) #4

Message was sent while issue was closed.

Closing, we landed Peter's change instead.