Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1348153003: Reland "Remove the 'gyp_config' concept from MB." (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Remove the 'gyp_config' concept from MB." This re-lands #349043 with some fixes for win32; we weren't consistently using os.sep everywhere. This patch fixes that and consolidates the code so that all references to os.sep and os.path.join() happen in the same places. In addition, this patch updates the unittests to run cleanly on win32 and test a win32-specific example (to catch the case that broke). TBR=scottmg@chromium.org BUG=481692 Committed: https://crrev.com/8c2cfd36d9ddcd4c1d6cc23b8e1dad2cc317e54c Cr-Commit-Position: refs/heads/master@{#349477}

Patch Set 1 : original (broken) patch #

Patch Set 2 : fixes and cleanup for win32 happiness #

Total comments: 1

Patch Set 3 : fix win32 test on non-win32 platform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -68 lines) Patch
M tools/mb/docs/user_guide.md View 1 3 chunks +2 lines, -5 lines 0 comments Download
M tools/mb/mb.py View 1 19 chunks +35 lines, -52 lines 0 comments Download
M tools/mb/mb_config.pyl View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/mb/mb_unittest.py View 1 2 7 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-17 00:25:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348153003/40001
5 years, 3 months ago (2015-09-17 00:26:48 UTC) #4
scottmg
Was it only tests that were failing before? Otherwise I don't understand how self.PathJoin and ...
5 years, 3 months ago (2015-09-17 00:32:02 UTC) #5
Dirk Pranke
No, there was a real bug (I've commented on the line that was wrong). https://codereview.chromium.org/1348153003/diff/40001/tools/mb/mb.py ...
5 years, 3 months ago (2015-09-17 00:41:24 UTC) #6
scottmg
Aha, I see. lgtm
5 years, 3 months ago (2015-09-17 00:44:15 UTC) #7
scottmg
(but I said that last time :)
5 years, 3 months ago (2015-09-17 00:44:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348153003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348153003/60001
5 years, 3 months ago (2015-09-17 00:51:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/114241)
5 years, 3 months ago (2015-09-17 01:36:54 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348153003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348153003/60001
5 years, 3 months ago (2015-09-17 02:09:39 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 02:39:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348153003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348153003/60001
5 years, 3 months ago (2015-09-17 20:06:13 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 3 months ago (2015-09-17 20:12:41 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:13:21 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8c2cfd36d9ddcd4c1d6cc23b8e1dad2cc317e54c
Cr-Commit-Position: refs/heads/master@{#349477}

Powered by Google App Engine
This is Rietveld 408576698