Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: BUILD.gn

Issue 1115533002: Build crash_service in Win GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/gn_migration.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1b00101d25865960eab747eb6866a8476fdfbad5..85a047b000c0dbf96660e611c9f1bdac187aa8c7 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -526,8 +526,7 @@ group("gn_all") {
"//base:pe_image_test",
"//chrome_elf:chrome_elf_unittests",
"//chrome_elf:dll_hash_main",
-
- # "//components/crash/tools:crash_service", TODO(GYP) - doesn't fully build yet.
+ "//components/crash/tools:crash_service",
"//components/wifi:wifi_test",
"//net:quic_client",
"//net:quic_server",
« no previous file with comments | « no previous file | build/gn_migration.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698