Move `gn check` into the `generate_build_files` step.

Move `gn check` into the `generate_build_files` step.

The dedicated GN bots run a script test step called `gn_check`
that (unsurprisingly) runs `gn check` to validate that we
haven't introduced any bad build dependencies.

When we enabled GN on the regular Linux bots, we forgot to add
that step. It turns out that we can't easily add it, because
the Linux bots use a builder/tester split, and the script would
run on the tester, where we don't have a build directory and
don't know what GN args to check against.

This patch changes the MB/generate_build_files step to add the
--check flag to the normal `gn gen` invocation. This slows
down the generate_build_files step, but the time would be spent
somewhere anyway when we ran the gn check step, later.

This patch also removes the explicit gn_check test step from
all of the bots. This patch will have the side effect of starting
to run `gn check` on *every* GN configuration (GN check was only
being run on some of the configurations before).

R=jam@chromium.org, brettw@chromium.org
BUG=532230
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Committed: https://crrev.com/b218d91ef159033438a8b79fc0ca8da7abdc2b8e
Cr-Commit-Position: refs/heads/master@{#349731}

[Dirk Pranke, 2015-09-15 23:25:17]

Patchset #1 (id:1) has been deleted

[Dirk Pranke, 2015-09-15 23:26:13]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2015-09-15 23:38:00]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-15 23:38:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342293002/20001

[brettw, 2015-09-15 23:42:09]

lgtm

[commit-bot: I haz the power, 2015-09-16 00:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 00:05:53]

Dry run: Transient error: Invalid delimiter in
"tryserver.chromium.mac.mac_chromium_gn_rel,mac_chromium_gn_dbg":
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[jam, 2015-09-16 00:17:09]

lgtm

[Dirk Pranke, 2015-09-16 18:34:42]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-09-16 18:35:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342293002/20001

[commit-bot: I haz the power, 2015-09-16 18:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 18:35:08]

Transient error: Invalid delimiter in
"tryserver.chromium.mac.mac_chromium_gn_rel,mac_chromium_gn_dbg":
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[Dirk Pranke, 2015-09-16 20:29:36]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-09-16 20:30:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342293002/20001

[commit-bot: I haz the power, 2015-09-16 20:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 20:41:04]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Dirk Pranke, 2015-09-16 20:59:20]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-16 21:01:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342293002/20001

[commit-bot: I haz the power, 2015-09-16 21:07:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 21:07:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_d...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Dirk Pranke, 2015-09-16 23:07:20]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-16 23:09:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342293002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342293002/60001

[commit-bot: I haz the power, 2015-09-17 01:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 01:16:20]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-09-17 01:33:38]

Brett: can you review the BUILD.gn changes, particularly the ones for the win
installer? I want to make sure I didn't introduce any improper dependencies.

I also sent you a note off-CL about the v8 issue that I'm seeing that led me to
disable checking for //components/html_viewer .

[brettw, 2015-09-17 20:28:32]

Let's revert the installer changes and remove it from the check list. We can get
back to that when we have more time to verify everything is OK.

LGTM with that.

[Dirk Pranke, 2015-09-17 20:31:57]

On 2015/09/17 20:28:32, brettw wrote:
> Let's revert the installer changes and remove it from the check list. We can
get
> back to that when we have more time to verify everything is OK.
> 
> LGTM with that.

Done.

[Dirk Pranke, 2015-09-17 20:32:03]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-09-17 20:32:03]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1342293002/#ps80001
(title: "back out installer changes, do not check //chrome/installer")

[commit-bot: I haz the power, 2015-09-17 20:32:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342293002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342293002/80001

[commit-bot: I haz the power, 2015-09-18 00:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 00:45:36]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Dirk Pranke, 2015-09-18 17:54:35]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-09-18 17:55:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342293002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342293002/80001

[commit-bot: I haz the power, 2015-09-18 19:07:08]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-09-18 19:08:01]

Patchset 4 (id:??) landed as
https://crrev.com/b218d91ef159033438a8b79fc0ca8da7abdc2b8e
Cr-Commit-Position: refs/heads/master@{#349731}