Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1114503002: [DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery. (Closed)

Created:
5 years, 7 months ago by dgozman
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, lcwu+watch_chromium.org, jam, yurys, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, aandrey+blink_chromium.org, android-webview-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@devtools-discovery-chrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery. BUG=476496 TBR=jochen Committed: https://crrev.com/88f570805c4cc7560bf527b8be4b8874740f35c2 Cr-Commit-Position: refs/heads/master@{#327300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -713 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D android_webview/browser/aw_dev_tools_manager_delegate.h View 1 chunk +0 lines, -38 lines 0 comments Download
D android_webview/browser/aw_dev_tools_manager_delegate.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M android_webview/native/aw_dev_tools_server.h View 2 chunks +0 lines, -4 lines 0 comments Download
M android_webview/native/aw_dev_tools_server.cc View 6 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/dev_tools_discovery_provider_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/android/dev_tools_manager_delegate_android.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/android/dev_tools_manager_delegate_android.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/browser/android/dev_tools_server.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 6 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 4 chunks +4 lines, -41 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 5 chunks +16 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_debugger.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chromecast/browser/devtools/cast_dev_tools_delegate.h View 2 chunks +1 line, -32 lines 0 comments Download
M chromecast/browser/devtools/cast_dev_tools_delegate.cc View 2 chunks +2 lines, -41 lines 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/devtools_discovery/devtools_target_descriptor.h View 2 chunks +38 lines, -5 lines 0 comments Download
M components/devtools_http_handler.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/devtools_http_handler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/devtools_http_handler/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler.h View 5 chunks +9 lines, -20 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 14 chunks +52 lines, -84 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/devtools_http_handler/devtools_http_handler_unittest.cc View 6 chunks +1 line, -34 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 2 chunks +1 line, -85 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/devtools_manager_delegate.h View 2 chunks +0 lines, -22 lines 0 comments Download
D content/public/browser/devtools_target.h View 1 chunk +0 lines, -67 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 5 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dgozman
Take a look please.
5 years, 7 months ago (2015-04-28 12:32:19 UTC) #2
pfeldman
lgtm
5 years, 7 months ago (2015-04-28 16:18:10 UTC) #3
dgozman
TBR'ing jochen@ for mass code remove.
5 years, 7 months ago (2015-04-28 16:19:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114503002/1
5 years, 7 months ago (2015-04-28 16:20:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 16:31:34 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 16:32:23 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/88f570805c4cc7560bf527b8be4b8874740f35c2
Cr-Commit-Position: refs/heads/master@{#327300}

Powered by Google App Engine
This is Rietveld 408576698