components/devtools_discovery/devtools_discovery_manager.h - Issue 1114503002: [DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_discovery/devtools_discovery_manager.h

Issue 1114503002: [DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devtools-discovery-chrome

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/devtools/remote_debugging_server.cc ('k') | components/devtools_discovery/devtools_target_descriptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_discovery/devtools_discovery_manager.h

diff --git a/components/devtools_discovery/devtools_discovery_manager.h b/components/devtools_discovery/devtools_discovery_manager.h

index fa2b630319d0d8f0a7034bd8b85a2ed5fd2b0cb0..d4f0e85dd976eda4e5eaab4318fe43299748b0a1 100644

--- a/components/devtools_discovery/devtools_discovery_manager.h

+++ b/components/devtools_discovery/devtools_discovery_manager.h

@@ -18,6 +18,8 @@ class DevToolsDiscoveryManager {

class Provider {

public:

virtual ~Provider() {}

+ // Caller takes ownership of created descriptors.

virtual DevToolsTargetDescriptor::List GetDescriptors() = 0;

};

@@ -31,6 +33,7 @@ class DevToolsDiscoveryManager {

void AddProvider(scoped_ptr<Provider> provider);

void SetCreateCallback(const CreateCallback& callback);

+ // Caller takes ownership of created descriptors.

DevToolsTargetDescriptor::List GetDescriptors();

scoped_ptr<DevToolsTargetDescriptor> CreateNew(const GURL& url);