chromecast/browser/devtools/remote_debugging_server.cc - Issue 1114503002: [DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/devtools/remote_debugging_server.cc

Issue 1114503002: [DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devtools-discovery-chrome

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/devtools/remote_debugging_server.h ('k') | components/devtools_discovery/devtools_discovery_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/devtools/remote_debugging_server.cc

diff --git a/chromecast/browser/devtools/remote_debugging_server.cc b/chromecast/browser/devtools/remote_debugging_server.cc

index 3b78e38bf53f4fecac0986c982d20ba7f0e0289c..6391b6d63035597090abd92bee27b300f89b25d5 100644

--- a/chromecast/browser/devtools/remote_debugging_server.cc

+++ b/chromecast/browser/devtools/remote_debugging_server.cc

@@ -148,12 +148,10 @@ void RemoteDebuggingServer::OnPortChanged() {

port_ = new_port;

if (port_ > 0) {

- manager_delegate_.reset(new CastDevToolsManagerDelegate());

devtools_http_handler_.reset(new DevToolsHttpHandler(

CreateSocketFactory(port_),

GetFrontendUrl(),

new CastDevToolsDelegate(),

- manager_delegate_.get(),

base::FilePath(),

std::string(),