Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: components/devtools_http_handler/devtools_http_handler_unittest.cc

Issue 1114503002: [DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devtools-discovery-chrome
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_http_handler/devtools_http_handler_unittest.cc
diff --git a/components/devtools_http_handler/devtools_http_handler_unittest.cc b/components/devtools_http_handler/devtools_http_handler_unittest.cc
index 6b794c2dd5464c8f89afb4b63c0777e38f4efbea..d2fdbbc60f7531fc07bc4e3ee9c82cd7dba61c55 100644
--- a/components/devtools_http_handler/devtools_http_handler_unittest.cc
+++ b/components/devtools_http_handler/devtools_http_handler_unittest.cc
@@ -7,9 +7,9 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
+#include "base/values.h"
#include "components/devtools_http_handler/devtools_http_handler.h"
#include "components/devtools_http_handler/devtools_http_handler_delegate.h"
-#include "content/public/browser/devtools_target.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_utils.h"
#include "net/base/ip_endpoint.h"
@@ -98,33 +98,6 @@ class DummyDelegate : public DevToolsHttpHandlerDelegate {
std::string GetFrontendResource(const std::string& path) override {
return std::string();
}
-};
-
-class DummyManagerDelegate : public content::DevToolsManagerDelegate {
- public:
- ~DummyManagerDelegate() override {}
-
- void Inspect(content::BrowserContext* browser_context,
- content::DevToolsAgentHost* agent_host) override {}
-
- void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
- bool attached) override {}
-
- base::DictionaryValue* HandleCommand(
- content::DevToolsAgentHost* agent_host,
- base::DictionaryValue* command) override {
- return NULL;
- }
-
- scoped_ptr<content::DevToolsTarget> CreateNewTarget(
- const GURL& url) override {
- return scoped_ptr<content::DevToolsTarget>();
- }
-
- void EnumerateTargets(TargetCallback callback) override {
- TargetList result;
- callback.Run(result);
- }
std::string GetPageThumbnailData(const GURL& url) override {
return std::string();
@@ -137,9 +110,6 @@ class DevToolsHttpHandlerTest : public testing::Test {
public:
DevToolsHttpHandlerTest() : testing::Test() { }
- protected:
- DummyManagerDelegate manager_delegate_;
-
private:
content::TestBrowserThreadBundle thread_bundle_;
};
@@ -153,7 +123,6 @@ TEST_F(DevToolsHttpHandlerTest, TestStartStop) {
new DevToolsHttpHandler(factory.Pass(),
std::string(),
new DummyDelegate(),
- &manager_delegate_,
base::FilePath(),
base::FilePath(),
std::string(),
@@ -175,7 +144,6 @@ TEST_F(DevToolsHttpHandlerTest, TestServerSocketFailed) {
new DevToolsHttpHandler(factory.Pass(),
std::string(),
new DummyDelegate(),
- &manager_delegate_,
base::FilePath(),
base::FilePath(),
std::string(),
@@ -204,7 +172,6 @@ TEST_F(DevToolsHttpHandlerTest, TestDevToolsActivePort) {
new DevToolsHttpHandler(factory.Pass(),
std::string(),
new DummyDelegate(),
- &manager_delegate_,
temp_dir.path(),
base::FilePath(),
std::string(),

Powered by Google App Engine
This is Rietveld 408576698