Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: content/public/browser/devtools_manager_delegate.h

Issue 1114503002: [DevTools] Cleanup DevToolsTarget and DevToolsManagerDelegate after moving to devtools_discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devtools-discovery-chrome
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/devtools_target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/devtools_manager_delegate.h
diff --git a/content/public/browser/devtools_manager_delegate.h b/content/public/browser/devtools_manager_delegate.h
index 5ebd854b10879be22b9b10cc56aa97e8528c0916..d34e7af3957ed5eea0cc835fb73cb348f45b4f4c 100644
--- a/content/public/browser/devtools_manager_delegate.h
+++ b/content/public/browser/devtools_manager_delegate.h
@@ -5,22 +5,14 @@
#ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_
#define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_
-#include <string>
-#include <vector>
-
-#include "base/callback.h"
-
namespace base {
class DictionaryValue;
}
-class GURL;
-
namespace content {
class BrowserContext;
class DevToolsAgentHost;
-class DevToolsTarget;
class DevToolsManagerDelegate {
public:
@@ -37,20 +29,6 @@ class DevToolsManagerDelegate {
virtual base::DictionaryValue* HandleCommand(
DevToolsAgentHost* agent_host,
base::DictionaryValue* command) = 0;
-
- // Creates new inspectable target.
- virtual scoped_ptr<DevToolsTarget> CreateNewTarget(const GURL& url) = 0;
-
- typedef std::vector<DevToolsTarget*> TargetList;
- typedef base::Callback<void(const TargetList&)> TargetCallback;
-
- // Requests the list of all inspectable targets.
- // The caller gets the ownership of the returned targets.
- virtual void EnumerateTargets(TargetCallback callback) = 0;
-
- // Get a thumbnail for a given page. Returns non-empty string iff we have the
- // thumbnail.
- virtual std::string GetPageThumbnailData(const GURL& url) = 0;
};
} // namespace content
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/devtools_target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698