Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1109473003: Get rid of TestNetLog::CapturedEntry[List] typedefs. (Closed)

Created:
5 years, 8 months ago by mmenke
Modified:
5 years, 8 months ago
Reviewers:
bengr, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of TestNetLog::CapturedEntry[List] typedefs. Replace them with CapturedNetLogEntry. BUG=none TBR=bengr@chromium.org Committed: https://crrev.com/16a7cbdd2de5af03e8eb9777a81d3f2d5613261f Cr-Commit-Position: refs/heads/master@{#326924}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -141 lines) Patch
M components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M net/cert/multi_log_ct_verifier_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_cache_unittest.cc View 7 chunks +8 lines, -6 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 10 chunks +10 lines, -9 lines 0 comments Download
M net/log/net_log_unittest.h View 12 chunks +15 lines, -14 lines 1 comment Download
M net/log/net_log_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/log/test_net_log.h View 2 chunks +5 lines, -8 lines 0 comments Download
M net/log/test_net_log.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/log/trace_net_log_observer_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_unittest.cc View 7 chunks +13 lines, -11 lines 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/proxy/proxy_script_decider_unittest.cc View 6 chunks +7 lines, -5 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 9 chunks +10 lines, -8 lines 0 comments Download
M net/socket/socks5_client_socket_unittest.cc View 6 chunks +7 lines, -5 lines 0 comments Download
M net/socket/socks_client_socket_unittest.cc View 7 chunks +8 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 10 chunks +12 lines, -11 lines 0 comments Download
M net/socket/transport_client_socket_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/spdy/spdy_session_unittest.cc View 7 chunks +8 lines, -6 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/udp/udp_socket_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 11 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mmenke
Inspired by your comment on the number of TODOs in net, I decided to tackle ...
5 years, 8 months ago (2015-04-24 22:31:09 UTC) #2
mmenke
https://codereview.chromium.org/1109473003/diff/1/net/log/net_log_unittest.h File net/log/net_log_unittest.h (right): https://codereview.chromium.org/1109473003/diff/1/net/log/net_log_unittest.h#newcode23 net/log/net_log_unittest.h:23: inline ::testing::AssertionResult LogContainsEventHelper( Think I'll de-inline these in a ...
5 years, 8 months ago (2015-04-24 22:31:39 UTC) #3
eroman
LGTM. I think we should be renaming CapturedNetLogEntry --> TestNetLogEntry to reflect the consumer's name ...
5 years, 8 months ago (2015-04-24 22:50:05 UTC) #4
mmenke
On 2015/04/24 22:50:05, eroman wrote: > LGTM. > > I think we should be renaming ...
5 years, 8 months ago (2015-04-24 22:53:26 UTC) #5
mmenke
TBRing bengr for DRP, since this is just a rename.
5 years, 8 months ago (2015-04-24 22:54:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109473003/1
5 years, 8 months ago (2015-04-24 22:55:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 23:01:02 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 23:02:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16a7cbdd2de5af03e8eb9777a81d3f2d5613261f
Cr-Commit-Position: refs/heads/master@{#326924}

Powered by Google App Engine
This is Rietveld 408576698