Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: net/log/test_net_log.h

Issue 1109473003: Get rid of TestNetLog::CapturedEntry[List] typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/test_net_log.h
diff --git a/net/log/test_net_log.h b/net/log/test_net_log.h
index 1526d8273011069100cb6054b50d9420759afbab..3099dedf12222fcbd03a5028a406aaebb38fc8c3 100644
--- a/net/log/test_net_log.h
+++ b/net/log/test_net_log.h
@@ -21,18 +21,15 @@ namespace net {
// net_test_support project.
class TestNetLog : public NetLog {
public:
- // TODO(mmenke): Get rid of these.
- typedef CapturedNetLogEntry CapturedEntry;
- typedef CapturedNetLogEntry::List CapturedEntryList;
-
TestNetLog();
~TestNetLog() override;
void SetCaptureMode(NetLogCaptureMode capture_mode);
// Below methods are forwarded to capturing_net_log_observer_.
- void GetEntries(CapturedEntryList* entry_list) const;
- void GetEntriesForSource(Source source, CapturedEntryList* entry_list) const;
+ void GetEntries(CapturedNetLogEntry::List* entry_list) const;
+ void GetEntriesForSource(Source source,
+ CapturedNetLogEntry::List* entry_list) const;
size_t GetSize() const;
void Clear();
@@ -56,11 +53,11 @@ class BoundTestNetLog {
BoundNetLog bound() const { return net_log_; }
// Fills |entry_list| with all entries in the log.
- void GetEntries(TestNetLog::CapturedEntryList* entry_list) const;
+ void GetEntries(CapturedNetLogEntry::List* entry_list) const;
// Fills |entry_list| with all entries in the log from the specified Source.
void GetEntriesForSource(NetLog::Source source,
- TestNetLog::CapturedEntryList* entry_list) const;
+ CapturedNetLogEntry::List* entry_list) const;
// Returns number of entries in the log.
size_t GetSize() const;

Powered by Google App Engine
This is Rietveld 408576698