Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: net/http/http_cache_unittest.cc

Issue 1109473003: Get rid of TestNetLog::CapturedEntry[List] typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache_unittest.cc
diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc
index d318e9180b6380369f02a42910b327ad0268df9d..1da77d8d96e27b5298194f3882af074ae1330d17 100644
--- a/net/http/http_cache_unittest.cc
+++ b/net/http/http_cache_unittest.cc
@@ -34,7 +34,9 @@
#include "net/http/http_transaction_test_util.h"
#include "net/http/http_util.h"
#include "net/http/mock_http_cache.h"
+#include "net/log/captured_net_log_entry.h"
#include "net/log/net_log_unittest.h"
+#include "net/log/test_net_log.h"
#include "net/socket/client_socket_handle.h"
#include "net/ssl/ssl_cert_request_info.h"
#include "net/websockets/websocket_handshake_stream_base.h"
@@ -532,7 +534,7 @@ class FakeWebSocketHandshakeStreamCreateHelper
// Returns true if |entry| is not one of the log types paid attention to in this
// test. Note that TYPE_HTTP_CACHE_WRITE_INFO and TYPE_HTTP_CACHE_*_DATA are
// ignored.
-bool ShouldIgnoreLogEntry(const TestNetLog::CapturedEntry& entry) {
+bool ShouldIgnoreLogEntry(const CapturedNetLogEntry& entry) {
switch (entry.type) {
case NetLog::TYPE_HTTP_CACHE_GET_BACKEND:
case NetLog::TYPE_HTTP_CACHE_OPEN_ENTRY:
@@ -548,7 +550,7 @@ bool ShouldIgnoreLogEntry(const TestNetLog::CapturedEntry& entry) {
// Modifies |entries| to only include log entries created by the cache layer and
// asserted on in these tests.
-void FilterLogEntries(TestNetLog::CapturedEntryList* entries) {
+void FilterLogEntries(CapturedNetLogEntry::List* entries) {
entries->erase(std::remove_if(entries->begin(), entries->end(),
&ShouldIgnoreLogEntry),
entries->end());
@@ -556,7 +558,7 @@ void FilterLogEntries(TestNetLog::CapturedEntryList* entries) {
bool LogContainsEventType(const BoundTestNetLog& log,
NetLog::EventType expected) {
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
log.GetEntries(&entries);
for (size_t i = 0; i < entries.size(); i++) {
if (entries[i].type == expected)
@@ -618,7 +620,7 @@ TEST(HttpCache, SimpleGETNoDiskCache) {
// Check that the NetLog was filled as expected.
// (We attempted to both Open and Create entries, but both failed).
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
log.GetEntries(&entries);
FilterLogEntries(&entries);
@@ -783,7 +785,7 @@ TEST(HttpCache, SimpleGET_LoadOnlyFromCache_Hit) {
log.bound(), &load_timing_info);
// Check that the NetLog was filled as expected.
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
log.GetEntries(&entries);
FilterLogEntries(&entries);
@@ -1141,7 +1143,7 @@ TEST(HttpCache, SimpleGET_LoadBypassCache) {
&load_timing_info);
// Check that the NetLog was filled as expected.
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
log.GetEntries(&entries);
FilterLogEntries(&entries);

Powered by Google App Engine
This is Rietveld 408576698