Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2367)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 1109473003: Get rid of TestNetLog::CapturedEntry[List] typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/log/net_log_unittest.h ('K') | « net/udp/udp_socket_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 18ec0f397a58654fbcf038740bd0aa47a9035fba..ded1f5cc9394ddd38f503bb59a9f6bee5aad7794 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -58,6 +58,7 @@
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_util.h"
+#include "net/log/captured_net_log_entry.h"
#include "net/log/net_log.h"
#include "net/log/net_log_unittest.h"
#include "net/log/test_net_log.h"
@@ -4163,7 +4164,7 @@ class AsyncDelegateLogger : public base::RefCounted<AsyncDelegateLogger> {
// DELEGATE_INFO NetLog events that an AsyncDelegateLogger should have
// recorded. Returns the index of entry after the expected number of
// events this logged, or entries.size() if there aren't enough entries.
- static size_t CheckDelegateInfo(const TestNetLog::CapturedEntryList& entries,
+ static size_t CheckDelegateInfo(const CapturedNetLogEntry::List& entries,
size_t log_position) {
// There should be 4 DELEGATE_INFO events: Two begins and two ends.
if (log_position + 3 >= entries.size()) {
@@ -4198,7 +4199,7 @@ class AsyncDelegateLogger : public base::RefCounted<AsyncDelegateLogger> {
// Find delegate request begin and end messages for OnBeforeNetworkStart.
// Returns the position of the end message.
static size_t ExpectBeforeNetworkEvents(
- const TestNetLog::CapturedEntryList& entries,
+ const CapturedNetLogEntry::List& entries,
size_t log_position) {
log_position =
ExpectLogContainsSomewhereAfter(entries,
@@ -4465,7 +4466,7 @@ TEST_F(URLRequestTestHTTP, DelegateInfoBeforeStart) {
EXPECT_EQ(URLRequestStatus::SUCCESS, r->status().status());
}
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log_.GetEntries(&entries);
size_t log_position = ExpectLogContainsSomewhereAfter(
entries,
@@ -4510,7 +4511,7 @@ TEST_F(URLRequestTestHTTP, NetworkDelegateInfo) {
EXPECT_EQ(1, network_delegate.destroyed_requests());
size_t log_position = 0;
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log_.GetEntries(&entries);
for (size_t i = 0; i < 3; ++i) {
log_position = ExpectLogContainsSomewhereAfter(
@@ -4567,7 +4568,7 @@ TEST_F(URLRequestTestHTTP, NetworkDelegateInfoRedirect) {
EXPECT_EQ(1, network_delegate.destroyed_requests());
size_t log_position = 0;
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log_.GetEntries(&entries);
// The NetworkDelegate logged information in OnBeforeURLRequest,
// OnBeforeSendHeaders, and OnHeadersReceived.
@@ -4649,7 +4650,7 @@ TEST_F(URLRequestTestHTTP, NetworkDelegateInfoAuth) {
EXPECT_EQ(1, network_delegate.destroyed_requests());
size_t log_position = 0;
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log_.GetEntries(&entries);
// The NetworkDelegate should have logged information in OnBeforeURLRequest,
// OnBeforeSendHeaders, OnHeadersReceived, OnAuthRequired, and then again in
@@ -4706,7 +4707,7 @@ TEST_F(URLRequestTestHTTP, URLRequestDelegateInfo) {
EXPECT_EQ(URLRequestStatus::SUCCESS, r->status().status());
}
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log_.GetEntries(&entries);
size_t log_position = 0;
@@ -4759,7 +4760,7 @@ TEST_F(URLRequestTestHTTP, URLRequestDelegateInfoOnRedirect) {
EXPECT_EQ(URLRequestStatus::SUCCESS, r->status().status());
}
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log_.GetEntries(&entries);
// Delegate info should only have been logged in OnReceivedRedirect and
@@ -4821,7 +4822,7 @@ TEST_F(URLRequestTestHTTP, URLRequestDelegateOnRedirectCancelled) {
EXPECT_EQ(URLRequestStatus::CANCELED, r->status().status());
}
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log.GetEntries(&entries);
// Delegate info is always logged in both OnReceivedRedirect and
@@ -7301,7 +7302,7 @@ TEST_F(HTTPSRequestTest, CipherFallbackTest) {
EXPECT_EQ(expected_version,
SSLConnectionStatusToVersion(r->ssl_info().connection_status));
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
net_log.GetEntries(&entries);
ExpectLogContainsSomewhere(entries, 0, NetLog::TYPE_SSL_CIPHER_FALLBACK,
NetLog::PHASE_NONE);
« net/log/net_log_unittest.h ('K') | « net/udp/udp_socket_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698