Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: net/spdy/spdy_session_unittest.cc

Issue 1109473003: Get rid of TestNetLog::CapturedEntry[List] typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session_unittest.cc
diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc
index 8e943cae0dffbfdfeed4e1c649f51fd9b5299cdc..9371012beb76145c50879530481855b6f9008a09 100644
--- a/net/spdy/spdy_session_unittest.cc
+++ b/net/spdy/spdy_session_unittest.cc
@@ -15,7 +15,9 @@
#include "net/base/request_priority.h"
#include "net/base/test_data_directory.h"
#include "net/base/test_data_stream.h"
+#include "net/log/captured_net_log_entry.h"
#include "net/log/net_log_unittest.h"
+#include "net/log/test_net_log.h"
#include "net/socket/client_socket_pool_manager.h"
#include "net/socket/next_proto.h"
#include "net/socket/socket_test_util.h"
@@ -1632,7 +1634,7 @@ TEST_P(SpdySessionTest, Initialize) {
// Flush the read completion task.
base::MessageLoop::current()->RunUntilIdle();
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
log.GetEntries(&entries);
EXPECT_LT(0u, entries.size());
@@ -1641,7 +1643,7 @@ TEST_P(SpdySessionTest, Initialize) {
entries, 0, NetLog::TYPE_HTTP2_SESSION_INITIALIZED, NetLog::PHASE_NONE);
EXPECT_LT(0, pos);
- TestNetLog::CapturedEntry entry = entries[pos];
+ CapturedNetLogEntry entry = entries[pos];
NetLog::Source socket_source;
EXPECT_TRUE(NetLog::Source::FromEventParameters(entry.params.get(),
&socket_source));
@@ -1677,7 +1679,7 @@ TEST_P(SpdySessionTest, NetLogOnSessionGoaway) {
EXPECT_TRUE(session == NULL);
// Check that the NetLog was filled reasonably.
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
log.GetEntries(&entries);
EXPECT_LT(0u, entries.size());
@@ -1686,7 +1688,7 @@ TEST_P(SpdySessionTest, NetLogOnSessionGoaway) {
entries, 0, NetLog::TYPE_HTTP2_SESSION_CLOSE, NetLog::PHASE_NONE);
if (pos < static_cast<int>(entries.size())) {
- TestNetLog::CapturedEntry entry = entries[pos];
+ CapturedNetLogEntry entry = entries[pos];
int error_code = 0;
ASSERT_TRUE(entry.GetNetErrorCode(&error_code));
EXPECT_EQ(OK, error_code);
@@ -1721,7 +1723,7 @@ TEST_P(SpdySessionTest, NetLogOnSessionEOF) {
EXPECT_TRUE(session == NULL);
// Check that the NetLog was filled reasonably.
- TestNetLog::CapturedEntryList entries;
+ CapturedNetLogEntry::List entries;
log.GetEntries(&entries);
EXPECT_LT(0u, entries.size());
@@ -1730,7 +1732,7 @@ TEST_P(SpdySessionTest, NetLogOnSessionEOF) {
entries, 0, NetLog::TYPE_HTTP2_SESSION_CLOSE, NetLog::PHASE_NONE);
if (pos < static_cast<int>(entries.size())) {
- TestNetLog::CapturedEntry entry = entries[pos];
+ CapturedNetLogEntry entry = entries[pos];
int error_code = 0;
ASSERT_TRUE(entry.GetNetErrorCode(&error_code));
EXPECT_EQ(ERR_CONNECTION_CLOSED, error_code);

Powered by Google App Engine
This is Rietveld 408576698