Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1102253002: Oilpan: keep FormData on the heap by default. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, tyoshino+watch_chromium.org, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: keep FormData on the heap by default. R=haraken BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M Source/core/html/DOMFormData.h View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/html/DOMFormData.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/html/FormData.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormDataList.h View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/html/FormDataList.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/loader/BeaconLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/FormSubmission.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/credentialmanager/Credential.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/credentialmanager/LocalCredential.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/fetch/Response.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSearchableFormData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 8 months ago (2015-04-27 07:17:23 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-27 08:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102253002/1
5 years, 8 months ago (2015-04-27 10:39:41 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 10:43:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194507

Powered by Google App Engine
This is Rietveld 408576698