Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: Source/core/html/FormDataList.h

Issue 1102253002: Oilpan: keep FormData on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/FormData.idl ('k') | Source/core/html/FormDataList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/FormDataList.h
diff --git a/Source/core/html/FormDataList.h b/Source/core/html/FormDataList.h
index b593b7d2a5f1d8126226111a05f410839a3e7af4..2cf78773690adbb62727e19181a16388af812ffc 100644
--- a/Source/core/html/FormDataList.h
+++ b/Source/core/html/FormDataList.h
@@ -32,8 +32,7 @@
namespace blink {
-class CORE_EXPORT FormDataList : public RefCountedWillBeGarbageCollected<FormDataList> {
- DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(FormDataList);
+class CORE_EXPORT FormDataList : public GarbageCollected<FormDataList> {
public:
class Entry final {
ALLOW_ONLY_INLINE_ALLOCATION();
@@ -80,12 +79,12 @@ public:
String m_filename;
};
- static PassRefPtrWillBeRawPtr<FormDataList> create(const WTF::TextEncoding& encoding)
+ static FormDataList* create(const WTF::TextEncoding& encoding)
{
- return adoptRefWillBeNoop(new FormDataList(encoding));
+ return new FormDataList(encoding);
}
- typedef PersistentHeapVectorWillBeHeapVector<FormDataList::Item> FormDataListItems;
+ using FormDataListItems = HeapVector<FormDataList::Item>;
void appendData(const String& key, const String& value)
{
@@ -111,7 +110,7 @@ public:
void deleteEntry(const String& key);
Entry getEntry(const String& key) const;
Entry getEntry(size_t index) const;
- WillBeHeapVector<Entry> getAll(const String& key) const;
+ HeapVector<Entry> getAll(const String& key) const;
bool hasEntry(const String& key) const;
void setBlob(const String& key, Blob*, const String& filename);
void setData(const String& key, const String& value);
« no previous file with comments | « Source/core/html/FormData.idl ('k') | Source/core/html/FormDataList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698