Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: Source/modules/credentialmanager/LocalCredential.h

Issue 1102253002: Oilpan: keep FormData on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/credentialmanager/Credential.h ('k') | Source/modules/fetch/Response.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/credentialmanager/LocalCredential.h
diff --git a/Source/modules/credentialmanager/LocalCredential.h b/Source/modules/credentialmanager/LocalCredential.h
index b7f716ede8df83659efec82877ab8a47544b30bd..cdc1abd2b9deae27a4447f1785b29302dbb4208c 100644
--- a/Source/modules/credentialmanager/LocalCredential.h
+++ b/Source/modules/credentialmanager/LocalCredential.h
@@ -34,7 +34,7 @@ public:
// LocalCredential.idl
const String& password() const;
- DOMFormData* formData() const { return m_formData.get(); };
+ DOMFormData* formData() const { return m_formData; };
DECLARE_VIRTUAL_TRACE();
@@ -42,8 +42,7 @@ private:
LocalCredential(WebLocalCredential*);
LocalCredential(const String& id, const String& password, const String& name, const KURL& avatar);
- // FIXME: Reconsider use of GarbageCollectedFinalized once this can be a Member.
- RefPtrWillBeMember<DOMFormData> m_formData;
+ Member<DOMFormData> m_formData;
};
} // namespace blink
« no previous file with comments | « Source/modules/credentialmanager/Credential.h ('k') | Source/modules/fetch/Response.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698