Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: Source/core/html/DOMFormData.cpp

Issue 1102253002: Oilpan: keep FormData on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/DOMFormData.h ('k') | Source/core/html/FormData.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/DOMFormData.cpp
diff --git a/Source/core/html/DOMFormData.cpp b/Source/core/html/DOMFormData.cpp
index b338643fd235508736c334b441b58daaecd23d0f..5ce324c51164613aab0286ef04439bab70d77b3e 100644
--- a/Source/core/html/DOMFormData.cpp
+++ b/Source/core/html/DOMFormData.cpp
@@ -68,7 +68,7 @@ public:
}
private:
- const RefPtrWillBeMember<DOMFormData> m_formData;
+ const Member<DOMFormData> m_formData;
size_t m_current;
};
@@ -116,9 +116,8 @@ void DOMFormData::get(const String& name, FormDataEntryValue& result)
Vector<FormDataEntryValue> DOMFormData::getAll(const String& name)
{
Vector<FormDataEntryValue> results;
- WillBeHeapVector<FormDataList::Entry> entries = FormDataList::getAll(name);
- for (size_t i = 0; i < entries.size(); ++i) {
- const FormDataList::Entry& entry = entries[i];
+ HeapVector<FormDataList::Entry> entries = FormDataList::getAll(name);
+ for (const FormDataList::Entry& entry : entries) {
ASSERT(entry.name() == name);
FormDataEntryValue value;
if (entry.isString())
« no previous file with comments | « Source/core/html/DOMFormData.h ('k') | Source/core/html/FormData.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698