Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: Source/core/loader/BeaconLoader.cpp

Issue 1102253002: Oilpan: keep FormData on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/BeaconLoader.h ('k') | Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/BeaconLoader.cpp
diff --git a/Source/core/loader/BeaconLoader.cpp b/Source/core/loader/BeaconLoader.cpp
index 35b056c4531ef9356c2ca410966587108784dc8e..b12dc62b51d6c09557628211e589bde3b24b56ff 100644
--- a/Source/core/loader/BeaconLoader.cpp
+++ b/Source/core/loader/BeaconLoader.cpp
@@ -37,12 +37,12 @@ protected:
static unsigned long long beaconSize(const String&);
static unsigned long long beaconSize(Blob*);
static unsigned long long beaconSize(PassRefPtr<DOMArrayBufferView>);
- static unsigned long long beaconSize(PassRefPtrWillBeRawPtr<DOMFormData>);
+ static unsigned long long beaconSize(DOMFormData*);
static bool serialize(const String&, ResourceRequest&, int, int&);
static bool serialize(Blob*, ResourceRequest&, int, int&);
static bool serialize(PassRefPtr<DOMArrayBufferView>, ResourceRequest&, int, int&);
- static bool serialize(PassRefPtrWillBeRawPtr<DOMFormData>, ResourceRequest&, int, int&);
+ static bool serialize(DOMFormData*, ResourceRequest&, int, int&);
};
template<typename Payload>
@@ -117,7 +117,7 @@ bool BeaconLoader::sendBeacon(LocalFrame* frame, int allowance, const KURL& beac
return Sender::send(frame, allowance, beaconURL, beacon, payloadLength);
}
-bool BeaconLoader::sendBeacon(LocalFrame* frame, int allowance, const KURL& beaconURL, PassRefPtrWillBeRawPtr<DOMFormData> data, int& payloadLength)
+bool BeaconLoader::sendBeacon(LocalFrame* frame, int allowance, const KURL& beaconURL, DOMFormData* data, int& payloadLength)
{
BeaconData<decltype(data)> beacon(data);
return Sender::send(frame, allowance, beaconURL, beacon, payloadLength);
@@ -219,13 +219,13 @@ bool Beacon::serialize(PassRefPtr<DOMArrayBufferView> data, ResourceRequest& req
return true;
}
-unsigned long long Beacon::beaconSize(PassRefPtrWillBeRawPtr<DOMFormData> data)
+unsigned long long Beacon::beaconSize(DOMFormData* data)
{
// DOMFormData's size cannot be determined until serialized.
return 0;
}
-bool Beacon::serialize(PassRefPtrWillBeRawPtr<DOMFormData> data, ResourceRequest& request, int allowance, int& payloadLength)
+bool Beacon::serialize(DOMFormData* data, ResourceRequest& request, int allowance, int& payloadLength)
{
ASSERT(data);
RefPtr<FormData> entityBody = data->createMultiPartFormData();
« no previous file with comments | « Source/core/loader/BeaconLoader.h ('k') | Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698